Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS handshake rate limit adjustment does not work for rustls 0.22 & 0.23 #3407

Closed
mstyura opened this issue Jun 19, 2024 · 0 comments · Fixed by #3408
Closed

TLS handshake rate limit adjustment does not work for rustls 0.22 & 0.23 #3407

mstyura opened this issue Jun 19, 2024 · 0 comments · Fixed by #3408
Labels
A-http project: actix-http A-web project: actix-web C-bug Category: bug

Comments

@mstyura
Copy link
Contributor

mstyura commented Jun 19, 2024

Your issue may already be reported! Please search on the Actix Web issue tracker before creating one.

Expected Behavior

HttpServer::method.max_connection_rate should allow to adjust TLS handshakes per second as suggested by documentation when used with any version of rustls or openssl.

Current Behavior

When used with rustls 0.22 or 0.23 due to conditional compilation part of code to adjust handshake per seconds is ingored.

Possible Solution

Will be provided as pull request.

Steps to Reproduce (for bugs)

  1. Receive > 256 new TLS connections per second per worker.

Context

In case of incoming TLS handshakes exceed default limit of 256 per second service to start accepting connection slower with part of the connections reset at TCP level.

Your Environment

  • Rust Version (I.e, output of rustc -V): rustc 1.79.0 (129f3b996 2024-06-10)
  • Actix Web Version: actix-web 4.7.0
@robjtede robjtede added C-bug Category: bug A-web project: actix-web A-http project: actix-http labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http A-web project: actix-web C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants