feat: minimal changes to get it working on vs2022 and dotnet 4.8 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
activescott
commented
Apr 26, 2024
•
activescott
commented
- Update nuint/xunit assemblies/dependencies to 4.8
- Confirm CI - that it builds and the binaries work on win 11
- consider versioning. Probably need to bump major as these dependencies are a breaking change
activescott
commented
Apr 26, 2024
|
@mega5800 Would be great if you can confirm this branch builds okay on your dev machine. Not urgent or critical, just would love for someone else to confirm it doesn't cause anyone a headache. :) |
activescott
commented
Apr 26, 2024
|
@activescott |
activescott
force-pushed
the
feat/target-dotnet-4.8-vs2022
branch
from
31cc368 to
334a984
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.