Skip to content

Fix shell issues + adjust linter #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 28, 2022
Merged

Fix shell issues + adjust linter #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ad87e1
nit
yoannchaudet Dec 28, 2022
a32bfc5
fix shellcheck workflow
yoannchaudet Dec 28, 2022
7476e98
fix linter issues
yoannchaudet Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/shellcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
pull_request:
paths:
- '**.sh'
# this is too wide but will cover shell scripts without an extension in that folder
- 'bin/*'

jobs:
shellcheck:
Expand Down
4 changes: 2 additions & 2 deletions bin/record_expected_output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ if [ "local" = "$1" ]; then
export PAGES_REPO_NWO=actions/jekyll-build-pages
export JEKYLL_BUILD_REVISION=JEKYLL_BUILD_REVISION

for dir in $(ls test_projects)
for dir in test_projects/*
do
bundle exec github-pages build --verbose -s test_projects/$dir -d test_projects/$dir/_expected
bundle exec github-pages build --verbose -s "test_projects/${dir}" -d "test_projects/${dir}/_expected"
done
else
act -b -s GITHUB_TOKEN -j record-expected-output
Expand Down
6 changes: 3 additions & 3 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#!/bin/bash

#######################################################################################################
####################################################################################################
#
# Calls github-pages executable to build the site using whitelisted plugins and supported configuration
# Calls github-pages executable to build the site using allowed plugins and supported configuration
#
#######################################################################################################
####################################################################################################

set -o errexit

Expand Down