Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.repos.deleteDeployKey is not a function #58

Closed
max4t opened this issue Jun 8, 2020 · 6 comments · Fixed by #59
Closed

github.repos.deleteDeployKey is not a function #58

max4t opened this issue Jun 8, 2020 · 6 comments · Fixed by #59

Comments

@max4t
Copy link

max4t commented Jun 8, 2020

Everything is in the title :)
Octokit doc

@jclem
Copy link
Contributor

jclem commented Jun 8, 2020

This isn't updated in lockstep with new releases of http://npm.im/@octokit/plugin-rest-endpoint-methods (in fact deleteDeployKey was added over the weekend less than 24 hours ago), as we rely on releases of https://npm.im/@actions/github for those dependencies.

When @actions/github is updated to use @octokit/plugin-rest-endpoint-methods v3.17.0, I'll update this action, as well.

@max4t
Copy link
Author

max4t commented Jun 8, 2020

Oh! My bad, I didn't see it has been just released.
I'll use removeDeployKey then.
Thanks!

@jclem
Copy link
Contributor

jclem commented Jun 8, 2020

@max4t I realized I can solve this sooner by making @octokit/* dependencies direct dependencies here instead of transitive. I should be able to land #59 tomorrow and resolve this.

@jclem jclem closed this as completed in #59 Jun 8, 2020
@jclem jclem reopened this Jun 8, 2020
@jclem
Copy link
Contributor

jclem commented Jun 8, 2020

(Reopened since I haven't done a release, yet). Just to confirm @max4t can you test your workflow with uses: actions/github-script@82b33c8? The deleteDeployKey method should be available there.

@max4t
Copy link
Author

max4t commented Jun 10, 2020

Perfect! Thanks 👍
(FYI, same goes for addDeployKey to createDeployKey, I had a warning about renaming it)

@moop-moop
Copy link

moop-moop commented Jun 12, 2020

uses: actions/github-script@82b33c8 fixed my issue with
repos.createStatus
https://octokit.github.io/rest.js/v16#repos-create-status
versus repos.createCommitStatus
https://octokit.github.io/rest.js/v18#repos-create-commit-status

After an hour wondering how repos.createCommitStatus was not a formula. 👍

@jclem jclem closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants