Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] warn-only set and job fails when having a vulnerability #824

Open
dolorsfg opened this issue Aug 28, 2024 · 0 comments
Open

[BUG] warn-only set and job fails when having a vulnerability #824

dolorsfg opened this issue Aug 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dolorsfg
Copy link

Describe the bug
This statement in documentation is not true: When warn-only is set to true, all vulnerabilities, independently of the severity, will be reported as warnings and the action will not fail. The vulnerabilities are reported as warnings but the job fails

To Reproduce
Steps to reproduce the behavior:

  1. Having previously configured dependency review as follows:
    uses: actions/dependency-review-action@v4
    with:
    comment-summary-in-pr: always
    fail-on-severity: high
    deny-licenses: GPL-1.0-or-later, LGPL-2.0-or-later
    warn-only: true
    base-ref: ${{ github.event.pull_request.base.sha || 'main' }}
    head-ref: ${{ github.event.pull_request.head.sha || github.ref }}
  2. Define a pom with this dependency:

    org.apache.tomcat.embed
    tomcat-embed-core
    10.1.24
    provided
  3. Create a PR to upload changes in pom
  4. Wait until dependency review finishes
  5. See that the vulnerability is correctly detected as a warning but the job fails

Expected behavior
The job ought not to fail

Screenshots
image
image

Action version
v4

Examples
https://github.com/dolorsfg/spring-demo/actions/runs/10593485619/job/29355095706?pr=1

@dolorsfg dolorsfg added the bug Something isn't working label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant