style: ruff updated to 0.0.243, pylint to 2.16.1

Author: actionless

.vimrc

@@ -1,4 +1,4 @@
 "let g:ale_linters = { 'python': ['ruff', 'pylsp'], }
-let g:ale_linters = { 'python': ['ruff', 'pylsp', 'flake8', ], }
+let g:ale_linters = { 'python': ['ruff', 'pylsp', 'flake8', 'pylint', 'mypy'], }
 let g:ale_python_vulture_options = ' ./maintenance_scripts/vulture_whitelist.py '
 autocmd VimEnter * :echo "local vimrc loaded! 😺"

maintenance_scripts/pikaman.py

@@ -55,7 +55,7 @@ def __init__(self, name: str = "test", section: int = 1) -> None:
         self.rules = {
             k: v
             for k, v in inspect.getmembers(self, predicate=inspect.ismethod)
-            if not (k.startswith("render") or k.startswith("_"))
+            if not (k.startswith(("render", "_")))
         }
 
     def render(
@@ -247,7 +247,7 @@ def escape(text: str) -> str:
 
     @staticmethod
     def is_url(text: str) -> bool:
-        return text.startswith("http://") or text.startswith("https://")
+        return text.startswith(("http://", "https://"))
 
     def document_open(self) -> str:
         date = datetime.datetime.now(tz=datetime.timezone.utc).strftime("%B %Y")

pikaur/makepkg_config.py

@@ -142,9 +142,9 @@ class MakePkgCommand:
     def _apply_dynamic_users_workaround(cls) -> None:
         pkgdest = str(get_pkgdest())
         if running_as_root() and pkgdest and (
-                pkgdest.startswith(str(_USER_TEMP_ROOT)) or
-                pkgdest.startswith("/tmp") or  # nosec B108  # noqa: S108
-                pkgdest.startswith("/var/tmp")  # nosec B108  # noqa: S108
+                pkgdest.startswith(
+                    (str(_USER_TEMP_ROOT), "/tmp", "/var/tmp"),  # nosec B108  # noqa: S108
+                )
         ):
             if not cls._cmd:
                 raise RuntimeError()

pikaur/pikspect.py

@@ -360,8 +360,7 @@ def cmd_output_reader_thread(self) -> None:
                 selected = select.select([self.pty_out], [], [], SMALL_TIMEOUT)
             except ValueError:  # pragma: no cover
                 return
-            else:
-                readers = selected[0]
+            readers = selected[0]
             if not readers:
                 if self.returncode is not None:
                     break

pikaur/updates.py

@@ -63,8 +63,7 @@ def get_remote_package(
         if aur_packages:
             return aur_packages[0]
         return None
-    else:
-        return repo_pkg
+    return repo_pkg
 
 
 def get_remote_package_version(new_pkg_name: str) -> str | None:

pyproject.toml

@@ -45,13 +45,20 @@ ignore = [
 	# enable back later:
 	"C901",  # "too complex"
 	"ERA001", # commented out code
+	# already managed by pulint, mb replace completely to ruff later:
+	"PLR0912",  # too many branches
+	"PLR0913",  # too many arguments
+	"PLR0915",  # too many statements
+
 
 	"ANN101",  # annotate self
 	"ANN102",  # annotate cls
 	"ANN401",  # disable Any
 
 	"BLE001",  # disallow catching Exception
 
+	"UP036", # remove code with py version checks
+
 	# docstrings
 	"D100",
 	"D101",
@@ -71,6 +78,10 @@ ignore = [
 ]
 
 [tool.ruff.per-file-ignores]
+"pikaur/argparse.py" = [
+	"PLR0912",
+	"PLR0915",
+]
 "pikaur_test/test_*.py" = [
 	"ANN201",
 	"ANN206",