Skip to content

Commit 0b471e6

Browse files
committed
test(cli): update the tests for multiword search - 2
1 parent 0cd3e4e commit 0b471e6

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

pikaur/search_cli.py

+5
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
)
1414
from .exceptions import AURError, SysExit
1515
from .i18n import translate
16+
from .logging_extras import create_logger
1617
from .pacman import PackageDB, get_pkg_id, refresh_pkg_db_if_needed
1718
from .pikaprint import print_error, print_stderr
1819
from .pikatypes import AURPackageInfo
@@ -29,6 +30,9 @@
2930
SamePackageTypeT = TypeVar("SamePackageTypeT", AURPackageInfo, pyalpm.Package)
3031

3132

33+
logger = create_logger("search")
34+
35+
3236
def filter_search_results(
3337
results: "dict[str, list[SamePackageTypeT]]",
3438
query: str,
@@ -73,6 +77,7 @@ def package_search_thread_aur( # pylint: disable=too-many-branches
7377
queries: list[str],
7478
) -> list[AURPackageInfo]:
7579
args = parse_args()
80+
logger.debug("queries: {}", queries)
7681
result = {}
7782
if queries:
7883
use_as_filters: list[str] = []

pikaur_test/test_cli.py

+14-15
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,10 @@ def test_search_multiword_too_small_query_error(self):
6969
self.assertEqual(len(result_aur_too_many), 0)
7070

7171
def test_search_multiword_too_small_query_filter(self):
72-
common_query = "mailman"
73-
specific_query = "u"
74-
common_result = "listadmin"
75-
specific_result = "mailman3-public-inbox"
72+
common_query = "fool"
73+
specific_query = "python"
74+
common_result = "fool"
75+
specific_result = "python-foolscap"
7676

7777
result_for_one_query = pikaur(f"-Ssq --aur {common_query}").stdout.splitlines()
7878
self.assertIn(specific_result, result_for_one_query)
@@ -83,27 +83,26 @@ def test_search_multiword_too_small_query_filter(self):
8383
self.assertNotIn(common_result, result_all)
8484

8585
def test_search_multiword_too_small_query_filter_namesonly(self):
86-
common_query = "mailman"
87-
specific_query = "d"
88-
specific_result = "listadmin"
89-
specific_query_names_only = "u"
90-
specific_result_names_only = "mailman3-public-inbox"
86+
common_query = "fool"
87+
specific_query = "python"
88+
specific_result = "python-ippserver"
89+
specific_result_names_only = "python-foolscap"
9190

9291
result_all = pikaur(
9392
f"-Ssq --aur {common_query} {specific_query}",
9493
).stdout.splitlines()
9594
self.assertIn(specific_result, result_all)
9695

97-
result_namesonly_w = pikaur(
96+
result_namesonly_1 = pikaur(
9897
f"-Ssq --aur {common_query} {specific_query} --namesonly",
9998
).stdout.splitlines()
100-
self.assertEqual(len(result_namesonly_w), 0)
99+
self.assertNotIn(specific_result, result_namesonly_1)
101100

102-
result_namesonly_x = pikaur(
103-
f"-Ssq --aur {common_query} {specific_query_names_only} --namesonly",
101+
result_namesonly_2 = pikaur(
102+
f"-Ssq --aur {common_query} {specific_query} --namesonly",
104103
).stdout.splitlines()
105-
self.assertNotIn(specific_result, result_namesonly_x)
106-
self.assertIn(specific_result_names_only, result_namesonly_x)
104+
self.assertNotIn(specific_result, result_namesonly_2)
105+
self.assertIn(specific_result_names_only, result_namesonly_2)
107106

108107
def test_list(self):
109108
result_all = pikaur("-Ssq").stdout.splitlines()

0 commit comments

Comments
 (0)