-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ARIA required owned elements" (bc4a75): Passed example 3 is incorrect #1552
Comments
I also couldn't help but notice that both SortSite, QualWeb, and axe-core pass that case. When I run axe-core directly against the test case, however, it does correctly fail, contrary to what's reported in the implementation data. QualWeb passes it for some reason. |
@kasperisager the expectation reads "Each test target only owns elements with a semantic role from the required owned element list for the test target's semantic role." So, I do think we need to update the expectation to require that the test target owns at least one element. |
@carlosapaduarte That's of course entirely correct! We've already implemented the bit about requiring at least one element in Alfa as per #1426 and I missed the fact that the published rule still doesn't include that change. |
I'm not so sure we should make them have required children TBH. Is there anything inaccessible about an empty row? |
Without it, I don't think the rule should exist at all: #1426 (comment) |
We should probably only write examples that are correct DOM/HTML. So not an example like that is parsed into a DOM different from what the HTML looks like. |
Closed by #1850. |
https://act-rules.github.io/testcases/bc4a75/c26f9f87576ea7fbeb2db67a559e78501d1d232a.html
When parsed as HTML, the above turns into the following:
That code fails the rule due to the row missing a cell.
The text was updated successfully, but these errors were encountered: