Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonshot waits forever after a rollback has completed #25

Closed
jamesiarmes opened this issue Mar 9, 2016 · 6 comments
Closed

Moonshot waits forever after a rollback has completed #25

jamesiarmes opened this issue Mar 9, 2016 · 6 comments
Labels

Comments

@jamesiarmes
Copy link
Contributor

Issue by cpliakas
Friday Dec 18, 2015 at 18:30 GMT
Originally opened as https://github.com/acquia/cloud-moonshot/issues/80


I made a mistake in my CloudFormation template, and the update operation rolled back. It looks like moonshot explicitly waits for the update to complete and doesn't handle the "rollback complete" status.

In the snippet below, to rollback completed in about 2 minutes.

[ \ ] [ 8m 37s ] Waiting for CloudFormation Stack to be successfully updated, current status 'UPDATE_ROLLBACK_COMPLETE'
@jamesiarmes
Copy link
Contributor Author

Comment by askreet
Friday Dec 18, 2015 at 18:58 GMT


This is a bug upstream, and has been fixed in aws-sdk-ruby:
aws/aws-sdk-ruby#931

We could maybe bump the required version in moonshot's gemspec to be sure you get a version with the fix. In the meantime, run bundle update locally and commit your updated Gemfile.lock.

@jamesiarmes
Copy link
Contributor Author

Comment by cpliakas
Friday Dec 18, 2015 at 21:19 GMT


Cool, thanks for the info on this.

I actually bundle update'ed today and for some reason I am stuck using 2.1.36 which was released on Nov 10. I even blew away Gemfile.lock and my gems directory and ran a clean bundle install and I still seem to be stuck on 2.1.36. Any guess as to why this is?

Latest seems to be 2.2.7 according to GitHub.

@jamesiarmes
Copy link
Contributor Author

Comment by codwazny
Friday Dec 18, 2015 at 21:25 GMT


I'm pretty sure moonshot is pinned to ~> 2.1.0 which should only update to the latest of the 2.1.X branch.

@jamesiarmes jamesiarmes added this to the 0.7.0 milestone Mar 9, 2016
@jamesiarmes jamesiarmes added the bug label Mar 9, 2016
@jamesiarmes
Copy link
Contributor Author

Comment by janost
Friday Jan 08, 2016 at 14:10 GMT


Yes @codwazny is right. I tried to update pipeline API to aws-sdk-ruby 2.2.x and bundler was complaining moonshot is pinned to 2.1.x.

@jamesiarmes
Copy link
Contributor Author

Comment by askreet
Friday Jan 08, 2016 at 15:34 GMT


@janost or anyone else, if you want to certify Moonshot works on v2.2.0 and change the gemspec, I'd be happy to merge that. I just haven't gone through testing it.

@jamesiarmes
Copy link
Contributor Author

Comment by janost
Friday Jan 08, 2016 at 15:35 GMT


@askreet Great, thanks. I'll get to it when I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant