Fixes #3796: Deploy command continues despite composer failure (#3809)

nhmbounteous · danepowell · commit 024239285c0f · 2019-08-14T11:06:04.000-07:00
* Made the deploy command fail and stop on `composer install` exception.

* Made the deploy command fail and stop on `composer install` exception.

* Update DeployCommand.php

Added space in between if statement for code standards

* Update DeployCommand.php

Updated composer error message
diff --git a/src/Robo/Commands/Deploy/DeployCommand.php b/src/Robo/Commands/Deploy/DeployCommand.php
@@ -488,10 +488,13 @@ protected function composerInstall() {
     if ($this->ignorePlatformReqs) {
       $command .= ' --ignore-platform-reqs';
     }
-    $this->taskExecStack()->exec($command)
+    $execution_result = $this->taskExecStack()->exec($command)
       ->stopOnFail()
       ->dir($this->deployDir)
       ->run();
+    if (!$execution_result->wasSuccessful()) {
+      throw new BltException("Composer install failed, please check the output for details.");
+    }
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -488,10 +488,13 @@ protected function composerInstall() {`
`488`	`488`	`if ($this->ignorePlatformReqs) {`
`489`	`489`	`$command .= ' --ignore-platform-reqs';`
`490`	`490`	`}`
`491`		`- $this->taskExecStack()->exec($command)`
	`491`	`+ $execution_result = $this->taskExecStack()->exec($command)`
`492`	`492`	`->stopOnFail()`
`493`	`493`	`->dir($this->deployDir)`
`494`	`494`	`->run();`
	`495`	`+ if (!$execution_result->wasSuccessful()) {`
	`496`	`+ throw new BltException("Composer install failed, please check the output for details.");`
	`497`	`+ }`
`495`	`498`	`}`
`496`	`499`
`497`	`500`	`/**`