-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): sablier helm chart for kube deployement #274
base: main
Are you sure you want to change the base?
Conversation
Hey @DrummyFloyd ! Thanks a lot for your contribution, I will look into it :) |
I'm not familiar with what's being done in most projects, should we have a folder Also for all the CI part I'm not familiar with helm testing. I'll need some time reviewing this 👍 This is some serious work though, thanks a lot for your contributions! |
no it's quite a convention the
for the CI part, is quite simple i use what i used on my own stuff + was inspired byt other open source stuff like traefik-chart
Np! |
Hello @DrummyFloyd I will create a new PR heavily inspired from your work. I'll mark you as a co author on the commit and this PR will be referenced! I'll close this PR once I'll submit the new one. |
Np problem =) |
The main issue is that the current CI you are using sets up a chart repository using the github pages. Currently the github pages feature is used to host the documentation. I'll check what I can do. |
We should also take car of helm best practices: https://helm.sh/docs/chart_best_practices/ There are some changes to be done for sa and rbac |
With the way I will be deploying multi versioned documentation, this will enable me to publish the helm chart! |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
spec: | ||
serviceAccountName: sablier-{{ .Release.Name }} | ||
containers: | ||
- name: sablier |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium
annotations: | ||
{{ toYaml . | nindent 8 }} | ||
{{- end }} | ||
spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium
Any updates on this @acouvreur |
I'm quite busy at the moment, but I think I can finish working on this next week :) |
Hi , like i said i n the issue, seems to be a good idea to have a chart to easily deploy sablier
NB: not very used to work with gh-actions, double check ^^
Closed: #271