-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard ssl support? #224
Comments
I'm not really familiar with how "templating" in Caddy would work. To me it seems that configuration is immutable. So I'm curious to see if you had any experience with "dynamic" configuration that may come from the routingitself, such as the targeted container. Your use case is obviously the most wanted one:
So far, not a single reverse proxy allows to do this kind of configuration at "request-time". |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Hey @acouvreur I figure'd it out. The request has to be built with the caddy http replacer during request time. I'm still working out the kinks but will provide a fork demonstrating this and leave it at your discretion on whether or not to include this functionality. |
Here's the code changes on my fork https://github.com/Bored0ne/sablier/blob/main/plugins/caddy/config.go |
Describe the bug
Not exactly a bug more of a use case that's being hindered. For a visual:
Basically my wildcard domain *.domain.com points to my Caddy server. My Caddy server then goes and allocates the record, traefik by default sets up the wildcard hosting with {{ .Containername }}.domain.com. Basically Sablier doesn't appear to support two things. 1. Placeholders in Caddy because the @name just gets sent to sablier as @name. 2. if it does not have sablier enabled but I try and connect to it via container name I just want sablier to ignore it's even calling it. Not error out like it currently is with a 404 healthcheck. Don't get me wrong I can appreciate what it is doing. However in my weird use case I don't want it to do that and would love to be able to set a config option to just ignore healthchecks on nonenabled containers.
Context
Expected behavior
It should support the magic.
The text was updated successfully, but these errors were encountered: