Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nomad provider #217

Open
livioribeiro opened this issue Oct 22, 2023 · 10 comments
Open

Add nomad provider #217

livioribeiro opened this issue Oct 22, 2023 · 10 comments
Labels
enhancement New feature or request provider Issue related to a provider

Comments

@livioribeiro
Copy link

Describe the provider
Nomad is an orchestrator from Hashicorp, similar to Kubernetes but with simpler deployment and operation.

Does the provider provides the following APIs
An instance is a generic term used to describe containers, pods, deployments, and more

API Yes No I don't know
Start an instance
Stop an instance
Get info about an instance
Listening for external events happening

Does the provider has a Go API SDK?
Yes https://pkg.go.dev/github.com/hashicorp/nomad/api

Does the provider can be started locally
Yes

@livioribeiro livioribeiro added enhancement New feature or request provider Issue related to a provider labels Oct 22, 2023
Copy link

github-actions bot commented Feb 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
@acouvreur acouvreur reopened this Feb 12, 2024
@acouvreur
Copy link
Owner

Unstale, I believe someone has something working

@github-actions github-actions bot removed the Stale label Feb 13, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 15, 2024
@acouvreur
Copy link
Owner

Unstale, issues will now be considered stale after a much longer peeiod of time

@github-actions github-actions bot removed the Stale label Mar 16, 2024
@ijcd
Copy link

ijcd commented May 24, 2024

Is there any work in progress for this that can be shared? What is involved in creating this?

@justmiles
Copy link

I've got a functional start here: https://github.com/justmiles/sablier

There are still a few bugs (mainly traffic being sent before the service is healthy) but feel free to jump in.

@ijcd
Copy link

ijcd commented Jul 2, 2024

@justmiles Cool, I can spend a bit of time on it. I haven't used sablier yet. I have nomad clusters with traefik border proxies that this could help with. I can look at the early-traffic issue -- any thoughts on how other plugins handle that? Where can I look for ideas?

@justmiles
Copy link

justmiles commented Jul 2, 2024

It seems to be that sablier is picking up that a service is healthy before traefik's service discovery configs have determined where to send it. After a refresh or two it gets in sync, though.

It's working well enough to solve my self-hosted needs, but I wouldn't push it to production in this current state. Would love a second set of eyes on it if you have the time.

@acouvreur
Copy link
Owner

acouvreur commented Jul 2, 2024

If you can have a single test with a Docker compose that sets up nomad, sablier, traefik and a service that'd be great!

It will definitely help setting things up to properly have this provider.
(Edit: you ready have all of that covered!)

You can submit a draft pull request targeting the beta branch!

We can also mark providers as unstable or non full feature ready, it's fine 🙂

@justmiles
Copy link

I started a draft PR but my fork is off of main. We'll need to rebase off of beta to get it ready-to-go. I haven't dug into the beta branch yet but looks like there's several changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request provider Issue related to a provider
Projects
None yet
Development

No branches or pull requests

4 participants