Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple docker sockets/proxy #162

Open
vutsalsinghal opened this issue Jul 14, 2023 · 6 comments
Open

Support multiple docker sockets/proxy #162

vutsalsinghal opened this issue Jul 14, 2023 · 6 comments

Comments

@vutsalsinghal
Copy link

vutsalsinghal commented Jul 14, 2023

Hi,

Love sablier!

I believe this is not super unusual to have multiple docker connections. For example - For example, I've three currently:

machine1:
  socket: /var/run/docker.sock

machine2:
  host: 192.168.0.81
  port: 10001

machine3:
  host: 192.168.0.81
  port: 10002

So basically in the subrequest to sablier backend from nginx (or traefik), when using docker provider, it should also pass something like sablierServer which can then be used to start/stop/query container status.

Homepage project (link) uses this concept to display the status and container stats.

@acouvreur
Copy link
Owner

Interesting! Seems easy to do!
Just to understand correctly, it's to support a customized docker endpoint right ?

Not the ability to connect to multiple docker deamons at once, is that correct ?

@vutsalsinghal
Copy link
Author

vutsalsinghal commented Jul 15, 2023

@acouvreur yes correct!

So maybe in the sablier.yml we can define all the endpoints (default can be /var/run/docker.sock) and in the subrequest call (with dynamic strat), along with the container name (sablierNames), we can also pass the endpoint name (like sablierServer=machine2) so the backend knows how to connect and start/stop/query the correct endpoint for that container.

Copy link

github-actions bot commented Feb 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
@acouvreur acouvreur reopened this Mar 15, 2024
@github-actions github-actions bot removed the Stale label Mar 16, 2024
@undaunt
Copy link

undaunt commented Mar 25, 2024

This would be great to have. I put as many containers as possible to the TCP endpoint of https://github.com/Tecnativa/docker-socket-proxy and only expose the portions of the socket that are needed instead of direct socket access.

@Sblop
Copy link

Sblop commented Apr 17, 2024

I agree on this. I prefer to use a docker proxy, instead of socket access.

This would be great to have. I put as many containers as possible to the TCP endpoint of https://github.com/Tecnativa/docker-socket-proxy and only expose the portions of the socket that are needed instead of direct socket access.

@thielj
Copy link

thielj commented Apr 19, 2024

Figured it out,... the docker client used picks up DOCKER_HOST and some other bits from the environment. See #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants