-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acorn-walk
does not work with injected plugins
#746
Comments
Good point. I don't think this worked pre-6.0 either. The problem appears to be that the functions exported from I'm not sure how we can work around this in a backwards-compatible way (apart from fragile hacks which depend on |
Thanks for the followup, this issue did exist pre-6.0 as well in my tests. I delayed reporting it since the migration to 6.0 was just beginning when I first encountered it. In retrospect, I should have filed it then.
That seems like a viable path forward to me. Will use the workaround you suggest until an official path forward is created. |
Hello,
I've been attempting to use
acorn-walk
with theacorn-dynamic-import
plugin both before and after the version 6 update. So far, have been quite unsuccessful with even the most basic examples.I created a repo demonstrating the issue: https://github.com/kristoferbaxter/dynamic-walk
Essentially it appears that extensions to
base
are not leveraged within thesimple
orancestor
methods.ampproject/rollup-plugin-closure-compiler#48 was the start of this issue – trying to add support for dynamic import to a rollup plugin for minification with closure compiler.
The text was updated successfully, but these errors were encountered: