-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can I help update the Bioconda package? #141
Comments
Hi Jon, sure I'd appreciate the help! That's correct that the updated dependencies for v0.9 (e.g. bioverbs) need to also be on bioconda, which is why the v0.7 release is currently pinned there. I'm in the process of finishing up the documentation on the package and submitting to Bioconductor soon. Are you also using bcbioSingleCell, or just some of the functions that work on |
For reference, the bioconda recipe is here: |
I'm mostly interested in the aggregation functions so I can collapse some technical replicates. Happy spend the time helping here rather than rolling my own. So shall I go ahead and build recipes for your dependencies? |
These are the new dependencies that need recipes for basejump v0.9: Everything should still be pinned against R 3.4 to work with bioconda. I split some of the functions in basejump out into these subpackages, making it a lot easier to unit test. |
Okay cool, I'll try those and ping you for reviews. |
Having trouble building goalie- I'm a little ignorant of the mechanisms of that package. Do you know what's needed in Bioconda to resolve the following?
|
Never mind, got it |
Weird yeah |
I /think/ it wasn't available before 3.4.2, and the Bioconda's 3.4 is 3.4.1. I think we need to use r-backports, and call backports::...elt . Some judicious sed in build.sh I think? |
Oh nice I think you're right and I didn't pick that up in my build checks. I'll work on adding that for R 3.4.1 compatibility. |
Okay good. The sed in build.sh works for now. I'll wait to push the recipe until the naming thing is resolved on bioconda/bioconda-recipes#13592 |
Can't put this on Bioconda yet because of the CI issues with its dependencies, but if you'd like to check the transformer recipe: https://github.com/bioconda/bioconda-recipes/compare/master...ebi-gene-expression-group:r-transformer?expand=1. Are the dependencies appropriate? It does build (using our group Conda channel temporarily for the dependencies). |
I've done all the recipes now, will progressively PR to Bioconda (CI fixed now) |
Thanks @pinin4fjords I finished pushing changes that ensure R 3.4 compatibility, so this should be good to go on bioconda. |
Thanks @mjsteinbaugh . The 3.4.1 issue went away when we stopped pinning (default is now 3.5.1). |
(though obviously you're right- people who need to use 3.4 along with your stuff can) |
Okay great, However, one thing we need to confirm first is that the recipes for Currently, it looks like the Recipe links: |
I'm afraid I'm tied up with other things now. Maybe you could sort those? I do have the basejump recipe ready to go when you're ready. |
I'll update those recipes. Thanks for the help @pinin4fjords |
Updated with this pull request: |
Hi!
I'd like to use the most up-to-date version of basejump for aggregating single-cell data. We're very Bioconda-centric, can I help update the Bioconda recipe? I just tried the dummy way of simply replacing the package source but that didn't work due to dependencies on your bioverbs etc- do they need their own Bioconda packages? If you give me a rough idea of what needs to be done I'll have another go.
Thanks,
Jon
The text was updated successfully, but these errors were encountered: