Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[candidate parameters] diagnosis fix #9365

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Sep 26, 2024

After We merge the diagnosis new feature into 26.0-release([New Feature] Tracking and Configuration of Candidate's Diagnosis Evolution (#7560)), it cause a bug.
if diagnosis is empty. the whole candidate param page will be broken.

@kongtiaowang kongtiaowang added Critical to release PR or issue is key for the release to which it has been assigned Category: Bug PR or issue that aims to report or fix a bug labels Sep 26, 2024
@kongtiaowang kongtiaowang changed the base branch from main to 26.0-release September 26, 2024 15:55
@kongtiaowang kongtiaowang added 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 and removed Critical to release PR or issue is key for the release to which it has been assigned labels Sep 26, 2024
@kongtiaowang kongtiaowang reopened this Sep 26, 2024
@CamilleBeau CamilleBeau self-requested a review September 27, 2024 15:06
@CamilleBeau CamilleBeau self-assigned this Sep 27, 2024
Copy link
Contributor

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is loading well now

@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Sep 27, 2024
@driusan driusan added this pull request to the merge queue Sep 27, 2024
Merged via the queue into aces:26.0-release with commit 760f302 Sep 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants