[candidate_list] Make candidate_list use LORIS streamable binary format #9195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the candidate_list module to use format=binary format instead of format=json. For large projects with many candidates the encoding of the data to JSON can use up all the server's memory and then crash with an out-of-memory error. Since the format=binary format is a line-based streamable format, it does not require loading the entire result set into memory before transmitting it to the client and larger data sets can be loaded into LORIS.
kongtiaowang
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the candidate_list module to use format=binary format instead of format=json. For large projects with many candidates the encoding of the data to JSON can use up all the server's memory and then crash with an out-of-memory error.
Since the format=binary format is a line-based streamable format, it does not require loading the entire result set into the server's memory to encode it to JSON before transmitting it to the client and larger data sets can be loaded into LORIS.