Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instrument_manager] Fixing error in generate_tables_sql_and_testNames tool #9157

Merged

Conversation

AlexandraLivadas
Copy link
Contributor

The tools/generate_tables_sql_and_testNames.php script is causing an error when uploading a new instrument using the Instrument Manager module. Since the output string was being reset to empty within the for-loop, the "Create Table" statement was not properly generated.

Testing instructions

  1. Go to the instrument manager module and try uploading the /test/instruments/test_all_fields.linst file
  2. Check that there is a success message and that the project folder and database are correctly updated with the new instrument.

@AlexandraLivadas AlexandraLivadas added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Mar 21, 2024
@AlexandraLivadas AlexandraLivadas requested a review from laemtl March 21, 2024 16:02
@laemtl laemtl self-requested a review March 21, 2024 16:07
Copy link
Contributor

@laemtl laemtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing :(
You gave a typo here:
$output = "": -> $output = "";

@ridz1208 ridz1208 requested a review from driusan March 26, 2024 18:48
@driusan driusan merged commit 591bac9 into aces:main Mar 26, 2024
28 checks passed
@driusan
Copy link
Collaborator

driusan commented Mar 26, 2024

I'm assuming there's no related issue this should close?

@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants