Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_tracker] Fix inactive user query #8904

Conversation

CamilleBeau
Copy link
Contributor

Brief summary of changes

This PR fixes the logic in the inactive users query for the assignee drop down of the issue tracker.

Previously, the query was missing brackets in the logic and was querying active users in the inactive users array. This resulted in all users being unset from the assignees object for users who do not have the "access_all_profiles" permission. With this PR, users without the "access_all_profiles" permission should be able to see the appropriate users in the assignee drop down of a new issue.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. In the 24.1-release branch, navigate to the issue tracker module with a user who does not have the "access_all_profiles" permission. Make sure you are on a database with several active and inactive users, especially at the same site(s) as the user you are using. Click on "New issue"
  2. Notice that the "assignee" drop down is blank
  3. Checkout this PR and refresh
  4. The "assignee" drop down should no longer be blank
  5. Check that only users who are active and at the same site as the user or DCC site are displayed in the assignee drop down.

@GeorgeMurad
Copy link
Contributor

LGTM

@racostas racostas self-requested a review February 1, 2024 19:51
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested in 24.1-release brach.

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Feb 1, 2024
@driusan driusan merged commit b7019c0 into aces:24.1-release Feb 1, 2024
9 checks passed
@driusan
Copy link
Collaborator

driusan commented Feb 1, 2024

Is there an issue associated with this that should be resolved/closed? There's nothing in the description.

@CamilleBeau
Copy link
Contributor Author

Is there an issue associated with this that should be resolved/closed? There's nothing in the description.

I think this probably came from an issue that we found on CCNA

@ridz1208 ridz1208 added this to the 24.1.7 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants