Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow module entrypoint to be written in typescript #8873

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Aug 24, 2023

There is an unnecessary ".js" added to the name resolution in webpack.config.js which forces the entrypoint of modules referred to by the config to be javascript. This removes it so that .ts/.tsx files can serve as the entrypoint to a module.

There is an unnecessary ".js" added to the name resolution in
webpack.config.js which forces the entrypoint of modules referred
to by the config to be javascript. This removes it so that
.ts/.tsx files can serve as the entrypoint to a module.
@driusan
Copy link
Collaborator Author

driusan commented Aug 24, 2023

@laemtl you're probably the only one who's worked with webpack.config.js.. can you review? It's a tiny change.

@HenriRabalais
Copy link
Collaborator

Yeah! Looks good to me — I guess my only question is that the previous code seemed to restrict it to .js file extensions. Is the idea to remove file extension qualification entirely? Or would it be preferable to add some sort of regex check to make sure it's either .js OR .ts OR .tsx

@driusan
Copy link
Collaborator Author

driusan commented Oct 16, 2023

I don't see why we would want to restrict the extension at all, if it's something that our webpack configuration supports.

Copy link
Collaborator

@HenriRabalais HenriRabalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@driusan driusan merged commit 9035962 into aces:main Nov 7, 2023
@ridz1208 ridz1208 added this to the 26.0.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants