Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix React upgrade regression #8651

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix React upgrade regression #8651

merged 1 commit into from
Apr 25, 2023

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Apr 19, 2023 •
edited
Loading

Fix all potential errors similar to the one solved here
Fixes #8578

@laemtl laemtl changed the base branch from main to 25.0-release April 19, 2023 17:53
@laemtl laemtl added this to the 25.0.0 milestone Apr 19, 2023
@laemtl laemtl requested a review from zaliqarosli April 21, 2023 12:44
@zaliqarosli
Copy link
Contributor

hey @laemtl how does this PR fix #8578? the issue is happening in the instruments module which I believe is not reactified. and this PR doesn't contain changes to instruments as far as i can tell

@driusan driusan merged commit 9941176 into aces:25.0-release Apr 25, 2023
@driusan driusan mentioned this pull request Apr 25, 2023
Closed
@zaliqarosli zaliqarosli mentioned this pull request Apr 26, 2023
Merged
@driusan driusan mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan approved these changes

@zaliqarosli zaliqarosli Awaiting requested review from zaliqarosli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.

[instruments] Error on saving LINST data
3 participants
@laemtl @zaliqarosli @driusan