[core] Remove \Module::factory, update remaining instances to $loris->getModule() #8287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Cleanup
driusan
force-pushed
the
MoreGetModule
branch
from
b4564d6 to
6f6d93d
Compare
…>getModule This finishes what was started in PR#8221 and eliminates the \Module::factory method. All remaining instances are updated to use $loris->getModule instead, which takes that LORISInstance module paths into consideration.
driusan
force-pushed
the
MoreGetModule
branch
from
ee402e8 to
f1dd58b
Compare
|
@ridz1208 ping.. I just rebased this because the required tests changed, but it was passing before the rebase. |
ridz1208
approved these changes
Feb 21, 2023
driusan
added a commit
to driusan/Loris
that referenced
this pull request
Feb 22, 2023
The main branch is failing since aces#8287 because when dashboard calls getWidgets() on the mri_violations module the module autoloader hasn't been loaded. This registers the autoloader when it's called so that the "new" class can be found.
driusan
added a commit
that referenced
this pull request
Feb 22, 2023
The main branch is failing since #8287 because when dashboard calls getWidgets() on the mri_violations module the module autoloader hasn't been loaded. This registers the autoloader when it's called so that the "new" class can be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes what was started in PR#8221 and eliminates the \Module::factory method. All remaining instances are updated to use $loris->getModule instead, which takes the LorisInstance module paths into consideration.