[core] Fix incorrect message/error for instrument access

[regisoc]

Brief summary of changes

An incorrect error message was displayed on the frontend when a user did not have the permission to access an instrument.
The code was test looping on ALL permissions, but it failed when trying to do so on only ONE permission (the loop went through the instrument name and permission instead of the actual instruments objects).
This PR fix the error message linked to permission listing.

Testing instructions (if applicable)

1. Add a new user
2. Give the user permissions through the db and config.xml file except one permission on one instrument (e.g. instrument "bmi", permission "data_entry")
3. Enter the permission selected in 2. in the config.xml file (instrumentPermissions section)
4. Go to Loris > Menu > Candidate > Access Profile
5. Choose one PSCID (candidate) then one associated visit (visit label)
6. In the "Behavioural Battery of Instruments", choose one instrument the user should not have access to according to the access rules
7. This should print the 403 page, with "You do not have access to this page." message

Link(s) to related issue(s)

• [Bug] Incorrect display error message when restricting access to an instrument #8171

[ridz1208]

@regisoc If I'm understanding correctly the issue is that when only 1 instrument permission is set it is treated like a string instead of an array but when more are set you get an array. If that is the case I would prefer one of the following fixes instead of making 2 different usecases:

1. fix the code generating the instrumentpermissions array and make sure it always returns an array even if there is a single one
2. do an is_array() check and if it returns false, wrap it in an array and then default to going to the forloop.

Option 1 would be the better option but it MIGHT (should be verified) affect other configurations in which case it might be a risky change for a bugfix.

[driusan]

The code generating the array is $config->getSetting which does have that behaviour, but can't be changed. The usual way to get that behaviour is to wrap it in a Utility::asArray call to ensure you're dealing with an array.

[regisoc]

I changed for the wrapper Utility::asArray.