[EEG Browser] Add ability to view annotations in event panel and overlaid on signal viewer #8235
Conversation
laemtl
force-pushed
the
2021_11_12_add_front_end_annotation_support
branch
2 times, most recently
from
a55921a to
37a9a93
Compare
|
@driusan Ready to be merged. |
modules/electrophysiology_browser/jsx/electrophysiologySessionView.js
Outdated
Show resolved
Hide resolved
laemtl
force-pushed
the
2021_11_12_add_front_end_annotation_support
branch
from
e246870 to
a0b5be5
Compare
laemtl
added
the
Blocking
|
@maltheism, we need a JS guru to review this, do you have time to take a look? |
| if (!(typeof text.json === 'string' | ||
| || text.json instanceof String)) return; | ||
| return tsvParse( | ||
| text.json.replace('trial_type', 'label')) | ||
| .map(({ onset, duration, label }, i) => ({ |
There was a problem hiding this comment.
@laemtl npm isn't complaining that there's a space before onset and after label? Otherwise the code looks great.
There was a problem hiding this comment.
Eslint doesn't complain but I can fix it!
There was a problem hiding this comment.
I don't have a personal preference regarding the format of the code but I'm concerned why eslint isn't working? Today I encountered that before & after "space" issue for code I was writing for ccna.
There was a problem hiding this comment.
Maybe because it's a ts file and not a js file?
There was a problem hiding this comment.
Exactly, the ESLint config is not including the .tsx at the moment.
I can enable eslint a bit later once all the EEG PRs will be merged, since it will impact all the files.
laemtl
added
the
Passed manual tests
Replaces #7828