[API] Add support for project names with space #7463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
changed the title
laemtl
force-pushed
the
2021-06-07-support-project-name-with-space
branch
3 times, most recently
from
e4df353 to
19d2c62
Compare
laemtl
changed the title
xlecours
reviewed
Jun 7, 2021
Comment on lines
104
to
106
| $project_name = isset($pathparts[1]) ? | ||
| urldecode($pathparts[1]) : | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| $project_name = isset($pathparts[1]) ? | |
| urldecode($pathparts[1]) : | |
| ''; | |
| $project_name = urldecode($pathparts[1] ?? ''); |
xlecours
approved these changes
Jun 7, 2021
|
And regarding the unicity of the project name, I think it is a good example of why the generic |
laemtl
force-pushed
the
2021-06-07-support-project-name-with-space
branch
from
19d2c62 to
05ae90d
Compare
Good suggestion, thanks! |
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Handle project names which need to be URL encoded in the API, such as projects with spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remark: Project names are not designed to be unique in the DB. In case of duplicates, the Project factory fails here (pselectRow used on a query that returns more than one row). (reported in #7464)