Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove duplicated getActiveModules function #7446

Merged
merged 9 commits into from
Oct 25, 2022

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented May 10, 2021

There was a static getActiveModules function in the module class
as well as a getActiveModules function in the LorisInstance class.

This removes the duplicate and unnecessary function, cleaning up the
references to the non-static version now that NDB_Page has a LorisInstance
object passed in the constructor and all references should be able to use
the non-static version.

@driusan
Copy link
Collaborator Author

driusan commented May 11, 2021

@kongtiaowang @ridz1208 can one of you review/test this? This is blocking the DQT API because, in removing the function, it also updates all the places that needed it to have access to a \LORIS\LorisInstance object, which is necessary for the final querying API.

@driusan driusan force-pushed the RemoveDuplicateFunction branch 2 times, most recently from 3aad732 to 4dd86a9 Compare May 17, 2022 18:55
There was a static getActiveModules function in the module class
as well as a getActiveModules function in the LorisInstance class.

This removes the duplicate and unnecessary function, cleaning up the
references to the non-static version now that NDB_Page has a LorisInstance
object passed in the constructor.
@driusan driusan force-pushed the RemoveDuplicateFunction branch from 01a5a7e to 7fff15b Compare October 24, 2022 18:10
@@ -79,7 +79,6 @@ class Dashboard extends \NDB_Form
// calculating the body.
$factory = \NDB_Factory::singleton();
$user = $factory->user();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss this change

@driusan driusan merged commit 528f4e3 into aces:main Oct 25, 2022
regisoc added a commit to regisoc/Loris that referenced this pull request Oct 27, 2022
Following aces#7446, one of the changes involves
`php/libraries/NullModule.class.inc` that now requires a
`LorisInstance` type parameter.

This fix adds this parameter in the lorisform_parser.php script.
driusan pushed a commit that referenced this pull request Nov 1, 2022
Following #7446, one of the changes involves php/libraries/NullModule.class.inc that now requires a LorisInstance type parameter.

This fix adds a missing parameter in the lorisform_parser.php script.
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants