[Statistics] fix behavioural tab without any project selection #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@racostas can you test this ASAP please |
|
Hi @ridz1208 , changes are looking good to me. I think the intention of the first condition was to limit the visit labels shown only to those belonging to the project selected: I would said if we want to be strict, when "All Projects" are selected we should show the visit labels for only the "all projects the current user have access to" which seen not to be the case with this fix. Anyway I think this could be a future feature. |
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
…6882) When no project is selected the behavioural tab should show results for all projects for all visits. instead it was just displaying an empty row see images.
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
…6882) When no project is selected the behavioural tab should show results for all projects for all visits. instead it was just displaying an empty row see images.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
…6882) When no project is selected the behavioural tab should show results for all projects for all visits. instead it was just displaying an empty row see images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
When no project is selected the behavioural tab should show results for all projects for all visits. instead it was just displaying an empty row see images.
before:
after:
