Instruments variable incorrectly defined

[ridz1208]

Brief summary of changes

This was showing up as an error on my IDE, the variable is defined as private in the hchild class while the parent class refers to it.

change from _select... to select... because static checks enforce the ugly _ before private variable rule

[lingma]

I am wondering whether it is necessary to change _selectMultipleElements to selectMultipleElements since the impacts to the existing instruments will be real. moreover, we have several other variables with the preifx _, obviously this is not mandatory to change right now.

If you change the name to without the prefix _, then there should be several more files to modify, not only these 2 files.

[driusan]

Can you make the comment more descriptive? Used for what?

[ridz1208]

@lingma as per the description yes it is mandatory by our static analyses tools

@driusan I can but do you know what it's used for ? Or do I dig deeper ?

[lingma]

@lingma as per the description yes it is mandatory by our static analyses tools

Then you need to modify several others files including at least 3 instruments in raisinbread, some wifi pages, instruments templates, and add this as a warning in the release guide.

[ridz1208]

@lingma please request changes and specify which classes need to be modified. Thanks

[driusan]

It looks like it's a list of multi-select elements kept so that they can be converted to/from {@} delimited on save.

[lingma]

docs/deprecated_wifi/How-to-Code-an-instrument.md: line 14 and 31 (maybe not necessary if this is deprecated)
instruments/NDB_BVL_Instrument_TEMPLATE.class.inc
instruments/NDB_BVL_Instrument_UPLOADER_TEMPLATE.class.inc
raisinbread/instruments/* (3 of them) aosi.class.inc, medical_history.class.inc, mri_parameter_form.class.inc

and add name change to the release warning or release important change zone

[johnsaigle]

I agee with Ling that the other files should be updated too. At least the Raisinbread instruments.

[ridz1208]

@lingma @johnsaigle does that cover everything ?

[driusan]

@ridz1208 the comment update is still missing

[lingma]

@ridz1208 the comment update is still missing

Right, the // is missing. In fact $this->selectMultipleElements = array(); or
//$this->selectMultipleElements = array(); should be the same.

[driusan]

No, I mean the update to the comment that I requested be updated 3 days ago because it's not very descriptive still isn't very descriptive.

[ridz1208]

@lingma i removed that comment on purpose, it's better to just declare the empty array

@driusan done. I didnt specify how it gets manipulated cause that should be the function's description, not the variable. but I just added that it should contain all multiselect fieds

[driusan]

@ridz1208 Makes sense to me, look better now.