[Core] Add LorisInstance class #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
force-pushed
the
LorisInstanceClass
branch
from
435fd1f to
a3b0e41
Compare
This adds a class to LORIS to represent an installed LORIS instance. It is primarily a stub that can be expanded in the future. Resolves aces#6022
driusan
force-pushed
the
LorisInstanceClass
branch
from
a3b0e41 to
2a8148c
Compare
Co-Authored-By: PapillonMcGill <[email protected]>
johnsaigle
added
the
Category: Feature
johnsaigle
reviewed
Mar 2, 2020
| * | ||
| * @param \Database $db A database connection to this | ||
| * instance. | ||
| * @param string[] $moduleDirs A list of directories that may |
There was a problem hiding this comment.
It might be nice to use SPLFileInfo instead especially if the main purpose of this property is to do validation based on the filepaths.
There was a problem hiding this comment.
That is not the main purpose. The main purpose is to have a list of directories that modules may be found in.
johnsaigle
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a class to LORIS to represent an installed LORIS instance.
It is primarily a stub that can be expanded in the future.
Resolves #6022