Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config files for static analysis tools to test/ directory #5871

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Move config files for static analysis tools to test/ directory #5871

merged 1 commit into from
Dec 17, 2019

Conversation

johnsaigle
Copy link
Contributor

Moves the config files for PHPCS and PHPMD to the test/ folder instead of the docs/ folder. These files aren't documents so they shouldn't be in this folder.

@johnsaigle johnsaigle added Cleanup PR or issue introducing/requiring at least one clean-up operation Meta PR does something that organizes, upgrades, or manages the functionality of the codebase labels Dec 17, 2019
@johnsaigle johnsaigle changed the title Move config files for static analysis tools to test/ directory [ci skip] Move config files for static analysis tools to test/ directory Dec 17, 2019
@johnsaigle johnsaigle mentioned this pull request Dec 17, 2019
Merged
driusan
driusan approved these changes Dec 17, 2019
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@driusan driusan merged commit 88c48d7 into aces:master Dec 17, 2019
@ridz1208 ridz1208 added this to the 23.0.0 milestone Dec 17, 2019
@ridz1208 ridz1208 added the Release: Add to release notes PR whose changes should be highlighted in the release notes label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan approved these changes

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Release: Add to release notes PR whose changes should be highlighted in the release notes
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsaigle @driusan @ridz1208