-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document LORIS automated testing #5859
Document LORIS automated testing #5859
Conversation
This is great. |
I'll add a line for alex.js ("don't say simply" tool). I'd rather keep phpcs and phpmd in this file. I'm looking at the document as being a place to send people when they're like "What is Travis, why is is failing" and this covers everything that Travis does. Whether something fails a test or is a style issue, both trigger the same kind and severity of problem from the perspective of someone trying to get a PR merged. |
@christinerogers I added a line for alex.js in the main PR discussing that tool. #5789 Since it won't actually be enforced in our automated testing suite (i.e. Travis), I think it's more appropriate in the Style Guide document. |
This may need updating after #5871 |
Co-Authored-By: Dave MacFarlane <[email protected]>
Co-Authored-By: Dave MacFarlane <[email protected]>
Co-Authored-By: Dave MacFarlane <[email protected]>
Last summer Alex Livadas wrote some text for developers in anticipation of these @johnsaigle - any content from Alex's General Dev Troubleshooting Guide doc |
The general troubleshooting guide isn't really relevant here. The other document you linked is deprecated as it's been converted into the UnitTestingGuide, which is already linked in the Unit Testing section of this document. |
Co-Authored-By: PapillonMcGill <[email protected]>
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Brief summary of changes
Adds a document that gives a high-level overview of our TravisCI pipeline.
This is intended as a general explainer of each of the tools we use. It will not include a list of each and every rule enforced by different tools nor provide example issues and solutions. Instead, links will be provided to the repositories of those tools as they'll be able to provide better detail than we can.
Content adapted from my presentation "How To Win The Love Of Travis".
Links to related tickets (GitHub, Redmine, ...)