-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Accounts] Hide UI option allowing users to edit their own approval status #5353
[User Accounts] Hide UI option allowing users to edit their own approval status #5353
Conversation
I think I'll have to update the integration tests |
@johnsaigle i made an attempt to fix the failing test, however I have a question. why not also hide the active field ? this way you cant lock urself out by setting it to no. |
@ridz1208 I updated this PR to also hide the active status as well as the active window. I'm not really clear on why you updated the integration test the way you did. Can you explain the changes? |
@johnsaigle The logged in user for testingg is UnitTester and the changes are being tested on the user itself. so obviously it's failing when it gets to testing the pending approval dropdown. I tried adding an other user and editing that one instead but I'm getting a weird duplicated value error when there should not be any other 999991 user from what I can tell. @kongtiaowang is looking into that particular error |
I will reopen this to debug Travis. |
Brief summary of changes
Fix #4743 where a user could accidentally lock themselves out but editing their own approval status.
Testing instructions (if applicable)
Pending Approval
fields when editing your own accounts