Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Add nodejs as a system requirement #5017

Merged
merged 3 commits into from
Aug 13, 2019
Merged

[README] Add nodejs as a system requirement #5017

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e18ed88
Add nodejs
johnsaigle Aug 12, 2019
101c53b
formatting
johnsaigle Aug 12, 2019
a132c16
testing change to johnsaigle's branch
christinerogers Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Deploy and log in with username *admin* and the password that's set up during de
* MySQL >= 5.7 (or MariaDB >= 10.3)
* PHP <b>7.2</b> or higher
* [Composer](https://getcomposer.org/)
* NodeJS <b>8.0</b> or higher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come to the conclusion 8.0 was the minimum version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truthfully I haven't done extensive testing.

v10 is the latest LTS though and v12 is current so I think v8 is an appropriate ask.


_Composer should be run with --no-dev option unless you are an active LORIS developer._

Expand Down