Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Readme] Reformatting, add "Contributing" and "Help" sections #4082

Merged
merged 22 commits into from
Jan 7, 2019
Merged

[Readme] Reformatting, add "Contributing" and "Help" sections #4082

merged 22 commits into from
Jan 7, 2019

Conversation

johnsaigle
Copy link
Contributor

@johnsaigle johnsaigle commented Nov 12, 2018

Brief summary of changes

Made a bunch of changes to the presentation of the Readme. This is obviously very subjective so let me know what you think.

I mainly tried to reduce duplication, change the format to highlight the most important areas, and encourage readers to open issues and reach out to us generally.

Also removed the build status chart and replaced it with the master build status which was placed beside the title.

@johnsaigle johnsaigle added Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) [branch] minor labels Nov 12, 2018
@johnsaigle johnsaigle changed the title [Readme] Display build status with title [Readme] Display build status in README project title instead of table Nov 12, 2018
@johnsaigle johnsaigle changed the title [Readme] Display build status in README project title instead of table [Readme] Add Contributing and Help sections Nov 14, 2018
@johnsaigle johnsaigle changed the title [Readme] Add Contributing and Help sections [Readme] Reformatting, add "Contributing" and "Help" sections Nov 14, 2018
@johnsaigle johnsaigle added Area: UI PR or issue related to the user interface Cleanup PR or issue introducing/requiring at least one clean-up operation labels Nov 14, 2018
README.md Outdated
include details such as the version of LORIS you're using as well as information
such as the OS you're using, your PHP and Apache versions, etc.

### Community
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community isn't a subset of help. Help is a subset of community.

paiva
paiva previously approved these changes Nov 22, 2018
Copy link
Contributor

@paiva paiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the markdown formatting. Looks good.

README.md Outdated
* Apache2
* MySQL 5.7
* PHP <b>7.2</b>
* Package manager (for LINUX distributions)
* Composer : should be run with --no-dev option
* A package manager, e.g. `apt`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache 2.4
MySQL 5.7+ or MariaDB 10.3+
PHP 7.2 or higher

We had a discussion on that in #3976

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yes I think I based this off of minor before the changes in 3976 were merged. I'll update the dependencies

README.md Outdated Show resolved Hide resolved
Co-Authored-By: johnsaigle <[email protected]>
PapillonMcGill
PapillonMcGill previously approved these changes Dec 17, 2018
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-Authored-By: johnsaigle <[email protected]>
@PapillonMcGill
Copy link
Contributor

PapillonMcGill commented Jan 7, 2019

would it be possible in step 4 of install,
to replace this line:
sudo service apache2 reload
with:
sudo systemctl reload apache2
to take advantage of SystemD tools?

Or would it be for another PR?

If a new PR is required, I approve this one.

@johnsaigle
Copy link
Contributor Author

I don't really know much about the difference between the two. From this post it seems like service might be more helpful because it does some extra checks for us.

What's is your preference for using the lower-level command over this one?

@PapillonMcGill
Copy link
Contributor

service is the old form. With systemD, systemctl is the new way to do it. If you call service with SystemD, a wrapper will pass the call to systemctl for backward compatibility (not exhaustive).

Lower level command is systemctl as no wrapper is involved

@johnsaigle
Copy link
Contributor Author

Apart from one being old and another new I'm still not sure why we would need to change the command here. service seems to be a wrapper for different init systems and is smart enough to redirect to systemctl when appropriate + does error-handling. I'm not sure why we'd change to something more specific and therefore potentially compatible with fewer environments.

Anyway I think this is probably a topic for a different PR since this is mostly just a formatting change.

@driusan driusan merged commit cc217cb into aces:minor Jan 7, 2019
@ridz1208 ridz1208 added this to the 20.3.0 milestone Jan 19, 2019
kchatpar pushed a commit to kchatpar/Loris that referenced this pull request Apr 15, 2019
)

Reword some sections of main README and improve formatting.

LORIS (Longitudinal Online Research and Imaging System) is a web-based data and project management software for neuroimaging research. LORIS makes it easy to manage large datasets including behavioural, clinical, neuroimaging and genetic data acquired over time or at different sites.
LORIS (Longitudinal Online Research and Imaging System) is a self-hosted web application that provides data- and project-management for neuroimaging research. LORIS makes it easy to manage large datasets including behavioural, clinical, neuroimaging and genetic data acquired over time or at different sites.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is extremely bolded by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI PR or issue related to the user interface Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants