Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flag] Remaining files referencing "Test_name" in flag table #9440

Open
CamilleBeau opened this issue Oct 31, 2024 · 1 comment · May be fixed by #9486
Open

[flag] Remaining files referencing "Test_name" in flag table #9440

CamilleBeau opened this issue Oct 31, 2024 · 1 comment · May be fixed by #9486
Assignees
@skarya22
Labels
Category: Bug PR or issue that aims to report or fix a bug

Comments

@CamilleBeau
Copy link
Contributor

CamilleBeau commented Oct 31, 2024 •
edited
Loading

Describe the bug
The following files still use "Test_name" column from flag even though this column was changed to TestID here #9338:

  1. tools/data_integrity_check.php
  2. modules/bvl_feedback/php/module.class.inc
  3. tools/detect_conflicts.php (already being fixed by [tools] Implement lorisInstance in tools directory #9397)
  4. php/libraries/Utility.class.inc
  5. tools/data_integrity/data_deletion/delete_timepoint.php
  6. tools/data_integrity/fix_candidate_age.php
  7. tools/fix_timepoint_date_problems.php
  8. tools/data_integrity/update_candidate_latest_diagnosis.php
  9. tools/importers/InstrumentImporter.php
  10. tools/data_integrity/score_instrument.php
@CamilleBeau CamilleBeau added the Category: Bug PR or issue that aims to report or fix a bug label Oct 31, 2024
@skarya22
Copy link
Contributor

Previously fixed:
2. modules/bvl_feedback/php/module.class.inc
6. tools/data_integrity/fix_candidate_age.php
8. tools/data_integrity/update_candidate_latest_diagnosis.php
9. tools/importers/InstrumentImporter.php
10. tools/data_integrity/score_instrument.php

@skarya22 skarya22 linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skarya22 skarya22

Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[flag] Fix remaining test_name flag skarya22/Loris
2 participants
@skarya22 @CamilleBeau