Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_dictionary_builder missing SourceFrom for LINST instruments #8861

Open
xlecours opened this issue Aug 10, 2023 · 0 comments
Open

data_dictionary_builder missing SourceFrom for LINST instruments #8861

xlecours opened this issue Aug 10, 2023 · 0 comments
Labels
Category: Bug PR or issue that aims to report or fix a bug

Comments

@xlecours
Copy link
Contributor

Describe the bug
When running data_dictionary_builder.php, SourceFrom is empty when there is no table line in the .linst file.
This is happening when the table is in the .meta file.

To Reproduce

cp raisinbread/instruments/bmi.* project/instruments/
cd tools
sed '1s/^/{-@-}/' -s ../project/instruments/bmi.linst >> ip_output.txt
cd exporters
php data_dictionary_builder.php

One way to fix that would be to also cat the .meta file into ip_output.txt. But data_dictionary_builder crashes when encountering the jsondata line. Just skipping the line would work.

Additional context
Noticed while testing #8845

@xlecours xlecours added the Category: Bug PR or issue that aims to report or fix a bug label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

No branches or pull requests

1 participant