Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[timepoint_list] Candidate Info and View Imaging Datasets buttons always appear #6673

Closed
driusan opened this issue Jun 8, 2020 · 3 comments · Fixed by #6815
Closed

[timepoint_list] Candidate Info and View Imaging Datasets buttons always appear #6673

driusan opened this issue Jun 8, 2020 · 3 comments · Fixed by #6815
Assignees
@CamilleBeau
Labels
Category: Bug PR or issue that aims to report or fix a bug

Comments

@driusan
Copy link
Collaborator

driusan commented Jun 8, 2020

While accessing a same-site candidate as a user with no permissions, the "Candidate Info" and "View Imaging Datasets" links always appear. They do not require the permissions required in the test plan (though clicking on them gives a permission denied error, so the modules linked to are properly enforcing permissions.)

(ie "Action Buttons" step 2 and 3 of the test plan fail.)
@driusan driusan added Category: Bug PR or issue that aims to report or fix a bug 23.0.0-testing labels Jun 8, 2020
@ridz1208
Copy link
Collaborator

ridz1208 commented Jul 2, 2020

@CamilleBeau please fix for 23.0-release

@CamilleBeau
Copy link
Contributor

From what I understand in the test plan, only "Candidate Info" and "Create time point" require the data entry permission to appear, but not "View Imaging datasets". What permissions are required for the "View Imaging Datasets" button to show?

  • For a candidate of the same site as your user, there should be up to 3 additional buttons:
    a. "Create time point" (links to create_timepoint module for that candidate) if your user has permission data_entry
    b. "Candidate Info" (links to candidate_parameters module for that candidate) if your user has permission data_entry
    c. "View Imaging Datasets" (links to the imaging_browser module menu page filtered for that candidate)

@CamilleBeau CamilleBeau mentioned this issue Jul 7, 2020
Merged
1 task
driusan pushed a commit that referenced this issue Jul 15, 2020
@CamilleBeau
[timepoint_list] Hiding Candidate Info and View Imaging Datasets butt…
750c710 
…ons (#6815)

This hides the "Candidate Info" and "View Imaging Datasets" buttons along with the "Create time point" button when the necessary permissions are not present. This was done with the assumption that "View Imaging Datasets" should only be visible if the user has one of the four imaging browser permissions (please correct me if this assumption is wrong). Test plan documentation was edited accordingly. If the user has none of the relevant permissions, the "Actions:" label is also hidden.

    Resolves #6673
@driusan
Copy link
Collaborator Author

driusan commented Aug 6, 2020

The PR was merged

@driusan driusan closed this as completed Aug 6, 2020
spell00 pushed a commit to spell00/Loris that referenced this issue Aug 13, 2020
@CamilleBeau @spell00
[timepoint_list] Hiding Candidate Info and View Imaging Datasets butt…
521a575 
…ons (aces#6815)

This hides the "Candidate Info" and "View Imaging Datasets" buttons along with the "Create time point" button when the necessary permissions are not present. This was done with the assumption that "View Imaging Datasets" should only be visible if the user has one of the four imaging browser permissions (please correct me if this assumption is wrong). Test plan documentation was edited accordingly. If the user has none of the relevant permissions, the "Actions:" label is also hidden.

    Resolves aces#6673
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 15, 2021
@CamilleBeau @AlexandraLivadas
[timepoint_list] Hiding Candidate Info and View Imaging Datasets butt…
73b647d 
…ons (aces#6815)

This hides the "Candidate Info" and "View Imaging Datasets" buttons along with the "Create time point" button when the necessary permissions are not present. This was done with the assumption that "View Imaging Datasets" should only be visible if the user has one of the four imaging browser permissions (please correct me if this assumption is wrong). Test plan documentation was edited accordingly. If the user has none of the relevant permissions, the "Actions:" label is also hidden.

    Resolves aces#6673
@nicolasbrossard nicolasbrossard mentioned this issue Dec 7, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CamilleBeau CamilleBeau

Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[timepoint_list] Hiding Candidate Info and View Imaging Datasets buttons CamilleBeau/Loris
3 participants
@driusan @ridz1208 @CamilleBeau