Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create object to represent a LORIS Instance #6022

Closed
driusan opened this issue Feb 5, 2020 · 2 comments · Fixed by #6118
Closed

Create object to represent a LORIS Instance #6022

driusan opened this issue Feb 5, 2020 · 2 comments · Fixed by #6118
Assignees
@driusan
Labels
Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered

Comments

@driusan
Copy link
Collaborator

driusan commented Feb 5, 2020

There is currently no concept of an installed LORIS instance for LORIS. Things that would logically belong in such a class tend to be scattered across the codebase in static functions or pseudo-globals (ie. the utility class, singletons, various factories) or be hardcoded with no canonical source of truth (ie. the project/ directory.)

We should create a class to represent the installed LORIS instance, pass it around where appropriate, and use it.
@driusan driusan added the Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered label Feb 5, 2020
@driusan driusan mentioned this issue Feb 5, 2020
Merged
@ridz1208
Copy link
Collaborator

ridz1208 commented Feb 5, 2020

👍

@driusan driusan self-assigned this Feb 5, 2020
@driusan driusan mentioned this issue Feb 14, 2020
Closed
@johnsaigle johnsaigle mentioned this issue Feb 20, 2020
Closed
@driusan
Copy link
Collaborator Author

driusan commented Feb 20, 2020

Blocked by #6023

@driusan driusan added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Feb 20, 2020
driusan added a commit to driusan/Loris that referenced this issue Feb 27, 2020
@driusan
[Core] Add LorisInstance class
435fd1f 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
@driusan driusan removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Feb 27, 2020
@driusan driusan mentioned this issue Feb 27, 2020
Merged
driusan added a commit to driusan/Loris that referenced this issue Feb 27, 2020
@driusan
[Core] Add LorisInstance class
a3b0e41 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
driusan added a commit to driusan/Loris that referenced this issue Feb 27, 2020
@driusan
[Core] Add LorisInstance class
2a8148c 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
driusan added a commit that referenced this issue Mar 3, 2020
@driusan
[Core] Add LorisInstance class (#6118)
553165c 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves #6022
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this issue Mar 3, 2020
@driusan @zaliqarosli
[Core] Add LorisInstance class (aces#6118)
14e7f5d 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
@johnsaigle johnsaigle mentioned this issue Mar 18, 2020
Merged
maltheism pushed a commit to maltheism/Loris that referenced this issue Apr 7, 2020
@driusan @Misotheism
[Core] Add LorisInstance class (aces#6118)
a6be8b0 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
laemtl pushed a commit to laemtl/Loris that referenced this issue Jun 10, 2020
@driusan @laemtl
[Core] Add LorisInstance class (aces#6118)
e86be99 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
laemtl pushed a commit to laemtl/Loris that referenced this issue Jun 16, 2020
@driusan @laemtl
[Core] Add LorisInstance class (aces#6118)
e9919c1 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
@driusan @AlexandraLivadas
[Core] Add LorisInstance class (aces#6118)
6cc6a38 
This adds a class to LORIS to represent an installed LORIS instance.

It is primarily a stub that can be expanded in the future.

Resolves aces#6022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driusan driusan

Labels
Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Add LorisInstance class driusan/Loris
2 participants
@driusan @ridz1208