Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PHPStan checks for modules/*/ajax/* and modules/*/test/* #6004

Closed
johnsaigle opened this issue Jan 29, 2020 · 2 comments
Closed

Enable PHPStan checks for modules/*/ajax/* and modules/*/test/* #6004

johnsaigle opened this issue Jan 29, 2020 · 2 comments
Labels
Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed Testing PR contains test plan or automated test code (or config files for Travis)

Comments

@johnsaigle
Copy link
Contributor

Additional context
These directories were originally ignored to facilitate the tool getting merged into LORIS. #5356
@johnsaigle johnsaigle added Testing PR contains test plan or automated test code (or config files for Travis) State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered labels Jan 29, 2020
@johnsaigle johnsaigle removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Feb 6, 2020
@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Apr 6, 2020
@driusan
Copy link
Collaborator

driusan commented Jan 21, 2025

I have tried to do this a few times over the years and every time I try and expand the scope of what phpstan covers it gets OOM errors. I don't think we can do this.

@driusan driusan closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driusan @johnsaigle