Skip to content

Commit

Permalink
[issue_tracker] Fix inactive user query (#8904)
Browse files Browse the repository at this point in the history
This fixes the logic in the inactive users query for the assignee drop down of the issue tracker.

The query was missing brackets in the logic and was querying active users in the inactive users array. This resulted in all users being unset from the assignees object for users who do not have the "access_all_profiles" permission. With brackets, users without the "access_all_profiles" permission should be able to see the appropriate users in the assignee drop down of a new issue.
  • Loading branch information
CamilleBeau authored Feb 1, 2024
1 parent 7d8f81d commit b7019c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/issue_tracker/php/edit.class.inc
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class Edit extends \NDB_Page implements ETagCalculator
$inactive_users_expanded = $db->pselect(
"SELECT DISTINCT u.Real_name, u.UserID FROM users u
LEFT JOIN user_psc_rel upr ON (upr.UserID=u.ID)
WHERE FIND_IN_SET(upr.CenterID,:CenterID) OR (upr.CenterID=:DCC)
WHERE (FIND_IN_SET(upr.CenterID,:CenterID) OR (upr.CenterID=:DCC))
AND Active='N'",
[
'CenterID' => $CenterID,
Expand Down

0 comments on commit b7019c0

Please sign in to comment.