From 0254ec0ed02639b56b0331a1dd58bc2f5a2a8eca Mon Sep 17 00:00:00 2001
From: CamilleBeau <51176779+CamilleBeau@users.noreply.github.com>
Date: Mon, 11 Nov 2024 13:31:54 -0500
Subject: [PATCH] [Feedback] Fix typo in getSummaryOfThreads (#8889)

This fixes the BVL Feedback summary in instruments by taking the
commentID for query params from the array _feedbackObjectInfo instead of
_feedbackCandidateProfileInfo, which only included candidate specific
data instead of instrument specific data.
---
 CHANGELOG.md                             | 1 +
 php/libraries/NDB_BVL_Feedback.class.inc | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7a9364cebe7..658fc13b17d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -166,6 +166,7 @@ the `Data` key instead of `$InstrumentName` (PR #7857)
 - Fixed broken DB calls in `assign_missing_instruments` and `instruments` (PR #8162)
 - Add support for PHP 8.1 (PR #7989)
 - Fix Project tab of Configuration module to give correct errors, and prevent saving without Alias (PR #8349)
+- Fix BVL feedback summary in instruments (PR #8889)
 ### Modules
 #### API
 - Ability to use PSCID instead of the CandID in the candidates API (PR #8138)
diff --git a/php/libraries/NDB_BVL_Feedback.class.inc b/php/libraries/NDB_BVL_Feedback.class.inc
index adf1d8aaa2d..11b01d8ee43 100644
--- a/php/libraries/NDB_BVL_Feedback.class.inc
+++ b/php/libraries/NDB_BVL_Feedback.class.inc
@@ -499,7 +499,7 @@ class NDB_BVL_Feedback
         }
         if (!empty($this->_feedbackObjectInfo['CommentID'])) {
             $query           .= " AND ft.CommentID = :ComID";
-            $qparams['ComID'] = $this->_feedbackCandidateProfileInfo['CommentID'];
+            $qparams['ComID'] = $this->_feedbackObjectInfo['CommentID'];
         }
 
         if (!$hasReadPermission) {