Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add isFSA check to isError #99

Merged
merged 1 commit into from
Jan 17, 2018
Merged

fix: add isFSA check to isError #99

merged 1 commit into from
Jan 17, 2018

Conversation

mov-78
Copy link
Contributor

@mov-78 mov-78 commented Jan 3, 2018

This prevents potential TypeErrors due to property access to null and undefined, and also make sure action is actually a FSA-complaint action object.

@coveralls
Copy link

coveralls commented Jan 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9efea41 on pwnn:patch-1 into 388ca8f on acdlite:master.

JaKXz
JaKXz approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This makes sense, thank you for the contribution :)

@JaKXz JaKXz merged commit b83c9ae into redux-utilities:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mov-78 @coveralls @JaKXz @pwNN