Refactor/depends on lodash

[tomchentw]

From #22 (comment)
@JaKXz instead of replacing lodash modular dependencies, would you consider switching dependencies to lodash main module and import from its entries? For example,

Before

import isPlainObject from 'lodash.isplainobject';
import isString from 'lodash.isstring';
import isSymbol from 'lodash.issymbol';

After

import isPlainObject from 'lodash/isPlainObject';
import isString from 'lodash/isString';
import isSymbol from 'lodash/isSymbol';

Thus, for those users who's also using lodash in their user space, the bundler (rollup/webpack) could resolve these modules and create a smaller output.

[coveralls]

Coverage remained the same at 100.0% when pulling 93824e8 on tomchentw:refactor/depends-on-lodash into f787b9d on acdlite:master.

[JaKXz]

@tomchentw thanks! though I still prefer what you originally suggested with lodash/isString etc.

Is there any reason you didn't use that [or am I missing something about how babel-plugin-lodash works]?

[tomchentw]

@JaKXz that's how it looks like when running yarn run build:

[JaKXz]

@tomchentw oh ok, cool. Would destructuring those methods out of lodash also produce that result?

[tomchentw]

@JaKXz I think so! Would you like switching to destructing format?

[JaKXz]

Yes, please :)

[tomchentw]

@JaKXz updated!

[coveralls]

Coverage remained the same at 100.0% when pulling a299fde on tomchentw:refactor/depends-on-lodash into 01e8fc3 on acdlite:master.

[coveralls]

Coverage remained the same at 100.0% when pulling a299fde on tomchentw:refactor/depends-on-lodash into 01e8fc3 on acdlite:master.

[JaKXz]

Thanks @tomchentw! I'm going to bed now but I will release this by the end of the week when I have OSS cycles again :)

In the meanwhile please feel free to install flux-standard-action#master and give it a whirl.

[JaKXz]

+ [email protected] finally published! sorry for the delay!

[tomchentw]

Awesome!