Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some package.json attributes within Template archive need rethinking. #787

Open
martinhalford opened this issue Jul 3, 2023 · 1 comment

Comments

@martinhalford
Copy link
Member

martinhalford commented Jul 3, 2023

Bug Report 🐛

The package.json contains some legacy artefacts which need to be removed or rethought.

Current Behaviour

An Accord Project template archive contains a package.json file containing the following definition:

    "accordproject": {
        "template": "clause",
        "cicero": "^0.24.0",
        "runtime": "ergo"
    },

The runtime attribute is redundant - should it be removed?

The template attribute seems to causes an error when using certain cicero commands (e.g. cicero archive), when it is set to contract - but the cicero commands seem to works fine when set to it is set to clause. It's probably still doing some sort of validation against the Ergo logic syntax - maybe?

Possible Solution

  • Remove the template and runtime attributes completely - unless there is some benefit to keeping them for future use.

Context (Environment)

  • cicero v0.24.0
  • node v19.9.0
@mttrbrts
Copy link
Sponsor Member

mttrbrts commented Jul 3, 2023

I made a start to this work in this PR.

[accordproject/cicero] Pull request opened: #786 BREAKING CHANGE(*): Remove dependency on Ergo. Remove Draft, Parse, Initialize, Trigger from API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants