Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot apply Black on White contrast theme after changing themes #2365

Open
1 task done
jobara opened this issue Nov 14, 2024 · 3 comments · May be fixed by #2374
Open
1 task done

Cannot apply Black on White contrast theme after changing themes #2365

jobara opened this issue Nov 14, 2024 · 3 comments · May be fixed by #2374
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
1.6.0

Comments

@jobara
Copy link
Collaborator

jobara commented Nov 14, 2024 •
edited
Loading

Prerequisites

Describe the bug

After changing between the various themes, attempting to go back to the black and white contrast theme doesn't change the theme.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the dev or staging sites
  2. Open the "Theme" drop down
  3. Change between several themes
  4. Change back to the "Black on White" theme
  5. Notice that it does not apply

Expected behavior

The theme should be applied when selected.

Screenshots

Screenshot Black on White theme selected but Grey on dark grey still applied

Additional context

I haven't been able to reproduce this locally but have experienced it on the dev and staging sites.
@jobara jobara added the bug Something isn't working label Nov 14, 2024
@jobara jobara added this to the 1.6.0 milestone Nov 14, 2024
@jobara
Copy link
Collaborator Author

jobara commented Nov 19, 2024

An additional related issue is that the theme picker doesn't work well with the keyboard. When trying to arrow through the options the first one or two are selected as expected but then the keyboard interaction breaks. This is also not reproducible in the production site and locally. I'd suspect that these are manifestations of the same or similar issues and are related to livewire re-rendering.

@jobara jobara added the help wanted Extra attention is needed label Nov 20, 2024
@jobara
Copy link
Collaborator Author

jobara commented Nov 21, 2024

Note this issue only happens with the theme picker at the top of the page. The contrast option in the user's settings can be changed without issue.

@jobara
Copy link
Collaborator Author

jobara commented Nov 25, 2024

@marvinroman has looked into this as well. It seems he wasn't able to reproduce it locally either, but running the following commands on both pods has fixed the issue. These have been run against development:

php artisan deploy:local
php artisan deploy:global

@marvinroman marvinroman linked a pull request Nov 26, 2024 that will close this issue
ci: migrate from rolling update to recreate #2374
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Public Launch
Status: Todo
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

ci: migrate from rolling update to recreate accessibility-exchange/platform
1 participant
@jobara