Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxRetries not getting set #85

Closed
BillBuilt opened this issue Oct 3, 2023 · 6 comments · Fixed by #86
Closed

MaxRetries not getting set #85

BillBuilt opened this issue Oct 3, 2023 · 6 comments · Fixed by #86

Comments

@BillBuilt
Copy link

Job MaxRetries field is not being saved and always defaults to '23':

err = tx.QueryRow(ctx, `INSERT INTO neoq_jobs(queue, fingerprint, payload, run_after, deadline)

@acaloiaro
Copy link
Owner

Thanks @BillBuilt -- confirmed. This will be fixed when #86 is merged.

@BillBuilt
Copy link
Author

Thanks! FWIW: I could not find any references to "max retries" in any of the backends, but I wasn't searching very thoroughly in the others.

@acaloiaro
Copy link
Owner

Retries for the Redis backend are implemented in asynq. However, the mem backend also appears to not be handling max retries correctly and that'll need to be fixed as well.

I'll use this as an opportunity to increase test coverage.

@acaloiaro
Copy link
Owner

Hi @BillBuilt I'm going to go ahead and merge the postgres fix for you and open up a new issue to work on the mem backend. Thanks for the report!

@BillBuilt
Copy link
Author

BillBuilt commented Oct 4, 2023 via email

@acaloiaro
Copy link
Owner

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants