Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not found if in subfolder with space in | media #30

Open
Zmove opened this issue Jul 22, 2020 · 6 comments
Open

Image not found if in subfolder with space in | media #30

Zmove opened this issue Jul 22, 2020 · 6 comments

Comments

@Zmove
Copy link

Zmove commented Jul 22, 2020

To reproduce :

Create a folder with a space in media directory, for example my folder/dummy.jpg

In your template, try to resize the image : <img src="{{ 'my folder/dummy.jpg'|media|resize(500) }}" />

You will get the image not found image instead of the one you defined.

If you replace "my folder" with "my_folder", it works, the problem come from the space in the folder name.

But it needs to be handled by this module, you can't explain to non technical client that they can't use space in their folder name (whereas the media library alow it).

Best regards,

@LukeTowers
Copy link
Contributor

@bennothommo can you add a test for this in the October core implementation?

@JumpLink
Copy link

Since the last update we also have the problem

@daslicht
Copy link

daslicht commented Aug 20, 2020

It doen't even work under some circumstances (still unclear which) if the name contains no spaces

@LukeTowers
Copy link
Contributor

@Zmove @JumpLink @daslicht if you guys could test out octobercms/october#5231 that would be great

@JumpLink
Copy link

@LukeTowers Are you working on core support for the feature? That`s great!

@LukeTowers
Copy link
Contributor

@JumpLink yes, it's been merged and will be available as a part of the L6 update in Build 469.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants