-
Notifications
You must be signed in to change notification settings - Fork 45
/
Copy pathproblems.py
709 lines (608 loc) · 26.8 KB
/
problems.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
import datetime
from collections import defaultdict
import logging
from operator import itemgetter
import random
from flask import (Blueprint, render_template, request, abort, url_for,
redirect, jsonify, g, flash)
from sqlalchemy import desc, func, and_, or_
from sqlalchemy.exc import SQLAlchemyError
from pyfaf.storage import (Arch,
Build,
BuildComponent,
BzBug,
MantisBug,
OpSysRelease,
OpSysComponent,
ProblemReassign,
OpSysComponentAssociate,
Package,
Problem,
ProblemComponent,
ProblemOpSysRelease,
Report,
ReportArch,
ReportBacktrace,
ReportBtFrame,
ReportBtTaintFlag,
ReportBtThread,
ReportBz,
ReportExecutable,
ReportHash,
ReportMantis,
ReportOpSysRelease,
ReportPackage,
ReportUnknownPackage,
Symbol,
SymbolSource)
from pyfaf.queries import (get_history_target, get_report,
get_external_faf_instances,
get_report_opsysrelease)
from pyfaf.solutionfinders import find_solution
from webfaf.webfaf_main import db, flask_cache
from webfaf.forms import (ProblemFilterForm, BacktraceDiffForm,
ProblemComponents, component_names_to_ids)
from webfaf.utils import (Pagination, request_wants_json, metric,
is_problem_maintainer)
problems = Blueprint("problems", __name__)
logger = logging.getLogger("webfaf.problems")
# pylint: disable=too-many-arguments,dangerous-default-value
def query_problems(_, hist_table,
opsysrelease_ids=[], component_ids=[],
associate_id=None, arch_ids=[], exclude_taintflag_ids=[],
types=[], rank_filter_fn=None, post_process_fn=None,
function_names=[], binary_names=[], source_file_names=[],
since_version=None, since_release=None,
to_version=None, to_release=None,
probable_fix_osr_ids=[], bug_filter=None,
limit=None, offset=None, solution=None):
"""
Return problems ordered by history counts
"""
rank_query = (db.session.query(Problem.id.label('id'),
func.sum(hist_table.count).label('rank'))
.join(Report, Report.problem_id == Problem.id)
.join(hist_table))
if opsysrelease_ids:
rank_query = rank_query.filter(
hist_table.opsysrelease_id.in_(opsysrelease_ids))
if rank_filter_fn:
rank_query = rank_filter_fn(rank_query)
if solution:
if not solution.data:
rank_query = rank_query.filter(or_(Report.max_certainty < 100, Report.max_certainty.is_(None)))
rank_query = rank_query.group_by(Problem.id).subquery()
final_query = (
db.session.query(Problem,
rank_query.c.rank.label('count'),
rank_query.c.rank)
.filter(rank_query.c.id == Problem.id)
.order_by(desc(rank_query.c.rank)))
if component_ids:
comp_query = (
db.session.query(ProblemComponent.problem_id.label('problem_id'))
.filter(ProblemComponent.component_id.in_(component_ids))
.distinct(ProblemComponent.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == comp_query.c.problem_id)
if associate_id:
assoc_query = (
db.session.query(ProblemComponent.problem_id.label('problem_id'))
.distinct(ProblemComponent.problem_id)
.join(OpSysComponent)
.join(OpSysComponentAssociate)
.filter(
OpSysComponentAssociate.associatepeople_id ==
associate_id)
.subquery())
final_query = final_query.filter(
Problem.id == assoc_query.c.problem_id)
if arch_ids:
arch_query = (
db.session.query(Report.problem_id.label('problem_id'))
.join(ReportArch)
.filter(ReportArch.arch_id.in_(arch_ids))
.distinct(Report.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == arch_query.c.problem_id)
if exclude_taintflag_ids:
etf_sq1 = (
db.session.query(ReportBtTaintFlag.backtrace_id.label("backtrace_id"))
.filter(ReportBtTaintFlag.taintflag_id.in_(exclude_taintflag_ids))
.filter(ReportBacktrace.id == ReportBtTaintFlag.backtrace_id))
etf_sq2 = (
db.session.query(ReportBacktrace.report_id.label("report_id"))
.filter(~etf_sq1.exists())
.filter(Report.id == ReportBacktrace.report_id))
etf_sq3 = (
db.session.query(Report.problem_id.label("problem_id"))
.filter(etf_sq2.exists())
.filter(Problem.id == Report.problem_id)
.distinct(Report.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == etf_sq3.c.problem_id)
if types:
type_query = (
db.session.query(Report.problem_id.label("problem_id"))
.filter(Report.type.in_(types))
.distinct(Report.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == type_query.c.problem_id)
if function_names or binary_names or source_file_names:
names_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportBacktrace)
.join(ReportBtThread)
.join(ReportBtFrame)
.join(SymbolSource)
.filter(ReportBtThread.crashthread == True)) #pylint: disable=singleton-comparison
if function_names:
names_query = (names_query.join(Symbol)
.filter(or_(*([Symbol.name.like(fn) for fn in function_names]+
[Symbol.nice_name.like(fn) for fn in function_names]))))
if binary_names:
names_query = names_query.filter(or_(*[SymbolSource.path.like(bn) for bn in binary_names]))
if source_file_names:
names_query = names_query.filter(or_(*[SymbolSource.source_path.like(sfn)
for sfn in source_file_names]))
names_query = names_query.distinct(Report.problem_id).subquery()
final_query = final_query.filter(Problem.id == names_query.c.problem_id)
if since_version or since_release or to_version or to_release:
version_query_known = (
db.session.query(Report.problem_id.label("problem_id"),
Build.semver.label("semver"),
Build.semrel.label("semrel"))
.join(ReportPackage)
.join(Package)
.join(Build)
.filter(ReportPackage.type == "CRASHED")
.distinct(Report.problem_id))
version_query_unknown = (
db.session.query(Report.problem_id.label("problem_id"),
ReportUnknownPackage.semver.label("semver"),
ReportUnknownPackage.semrel.label("semrel"))
.join(ReportUnknownPackage)
.filter(ReportUnknownPackage.type == "CRASHED")
.distinct(Report.problem_id))
version_query = (version_query_known.union(version_query_unknown)
.distinct(Report.problem_id))
# Make sure only builds of the selected components are considered
# Requires the find-components action to be run regularly
if component_ids:
version_query = (
version_query
.join(BuildComponent)
.filter(BuildComponent.component_id.in_(component_ids))
)
if since_version and since_release:
version_query = version_query.filter(
or_(
or_(
and_(Build.semver == since_version,
Build.semrel >= since_release),
Build.semver > since_version
),
or_(
and_(ReportUnknownPackage.semver == since_version,
ReportUnknownPackage.semrel >= since_release),
ReportUnknownPackage.semver > since_version
)
)
)
elif since_version:
version_query = version_query.filter(
or_(
Build.semver >= since_version,
ReportUnknownPackage.semver >= since_version
)
)
elif since_release:
version_query = version_query.filter(
or_(
Build.semrel >= since_release,
ReportUnknownPackage.semrel >= since_release
)
)
if to_version and to_release:
version_query = version_query.filter(
or_(
or_(
and_(Build.semver == to_version,
Build.semrel <= to_release),
Build.semver < to_version
),
or_(
and_(ReportUnknownPackage.semver == to_version,
ReportUnknownPackage.semrel <= to_release),
ReportUnknownPackage.semver < to_version
)
)
)
elif to_version:
version_query = version_query.filter(
or_(
Build.semver <= to_version,
ReportUnknownPackage.semver <= to_version
)
)
elif to_release:
version_query = version_query.filter(
or_(
Build.semrel <= to_release,
ReportUnknownPackage.semrel <= to_release
)
)
ver_sq = version_query.subquery()
final_query = final_query.filter(Problem.id == ver_sq.c.problem_id)
if probable_fix_osr_ids:
pf_query = (
db.session.query(ProblemOpSysRelease.problem_id.label("problem_id"))
.filter(ProblemOpSysRelease.opsysrelease_id.in_(probable_fix_osr_ids))
.filter(ProblemOpSysRelease.probable_fix_build_id.isnot(None))
.distinct(ProblemOpSysRelease.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == pf_query.c.problem_id)
if bug_filter == "HAS_BUG":
# Has bugzilla
bz_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportBz)
)
# Has mantis bug
mantis_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportMantis)
)
# Union
bug_query = (bz_query.union(mantis_query)
.distinct(Report.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == bug_query.c.problem_id)
elif bug_filter == "NO_BUGS":
# No bugzillas
bz_query = (
db.session.query(Report.problem_id.label("problem_id"))
.outerjoin(ReportBz)
.group_by(Report.problem_id)
.having(func.count(ReportBz.report_id) == 0)
)
# No Mantis bugs
mantis_query = (
db.session.query(Report.problem_id.label("problem_id"))
.outerjoin(ReportMantis)
.group_by(Report.problem_id)
.having(func.count(ReportMantis.report_id) == 0)
)
# Intersect
bug_query = (bz_query.intersect(mantis_query)
.distinct(Report.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == bug_query.c.problem_id)
elif bug_filter == "HAS_OPEN_BUG":
# Has nonclosed bugzilla
bz_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportBz)
.join(BzBug)
.filter(BzBug.status != "CLOSED")
)
# Has nonclosed Mantis bug
mantis_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportMantis)
.join(MantisBug)
.filter(MantisBug.status != "CLOSED")
)
# Union
bug_query = (bz_query.union(mantis_query)
.distinct(Report.problem_id)
.subquery())
final_query = final_query.filter(Problem.id == bug_query.c.problem_id)
elif bug_filter == "ALL_BUGS_CLOSED":
# Has no bugzilla or no nonclosed bugs
bz_query = (
db.session.query(Report.problem_id.label("problem_id"))
.outerjoin(ReportBz)
.outerjoin(BzBug)
.filter(or_(ReportBz.report_id.is_(None), BzBug.status != "CLOSED"))
.group_by(Report.problem_id)
.having(func.count(ReportBz.report_id) == 0)
)
# Has no Mantis bug or no nonclosed Mantis bugs
mantis_query = (
db.session.query(Report.problem_id.label("problem_id"))
.outerjoin(ReportMantis)
.outerjoin(MantisBug)
.filter(or_(ReportMantis.report_id.is_(None), MantisBug.status != "CLOSED"))
.group_by(Report.problem_id)
.having(func.count(ReportMantis.report_id) == 0)
)
# Intersection gives us also probles with no bugzillas or Mantis bugs
bug_query_not_closed = bz_query.intersect(mantis_query)
# We need to intersect this with problems having bugs
bz_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportBz)
)
mantis_query = (
db.session.query(Report.problem_id.label("problem_id"))
.join(ReportMantis)
)
bug_query = (bz_query.union(mantis_query).intersect(bug_query_not_closed)
.distinct(Report.problem_id)
.subquery())
# For some reason the "problem_id" label gets lost in all the
# unions and intersects so we need to access through items()
final_query = final_query.filter(Problem.id == list(bug_query.c.items())[0][1])
if limit > 0:
final_query = final_query.limit(limit)
if offset >= 0:
final_query = final_query.offset(offset)
problem_tuples = final_query.all()
if post_process_fn:
problem_tuples = post_process_fn(problem_tuples)
for problem, count, _ in problem_tuples:
problem.count = count
return [x[0] for x in problem_tuples]
def get_problems(filter_form, pagination):
opsysrelease_ids = [
osr.id for osr in (filter_form.opsysreleases.data or [])]
component_ids = component_names_to_ids(filter_form.component_names.data)
if filter_form.associate.data:
associate_id = filter_form.associate.data.id
else:
associate_id = None
arch_ids = [arch.id for arch in (filter_form.arch.data or [])]
types = filter_form.type.data or []
exclude_taintflag_ids = [
tf.id for tf in (filter_form.exclude_taintflags.data or [])]
(since_date, to_date) = filter_form.daterange.data
date_delta = to_date - since_date
if date_delta < datetime.timedelta(days=16):
resolution = "daily"
elif date_delta < datetime.timedelta(weeks=10):
resolution = "weekly"
else:
resolution = "monthly"
hist_table, hist_field = get_history_target(resolution)
probable_fix_osr_ids = [
osr.id for osr in (filter_form.probable_fix_osrs.data or [])]
p = query_problems(db,
hist_table,
opsysrelease_ids,
component_ids,
associate_id,
arch_ids,
exclude_taintflag_ids,
types,
lambda query: (
query.filter(hist_field >= since_date)
.filter(hist_field <= to_date)),
function_names=filter_form.function_names.data,
binary_names=filter_form.binary_names.data,
source_file_names=filter_form.source_file_names.data,
since_version=filter_form.since_version.data,
since_release=filter_form.since_release.data,
to_version=filter_form.to_version.data,
to_release=filter_form.to_release.data,
probable_fix_osr_ids=probable_fix_osr_ids,
bug_filter=filter_form.bug_filter.data,
limit=pagination.limit,
offset=pagination.offset,
solution=filter_form.solution)
return p
def problems_list_table_rows_cache(filter_form, pagination):
key = ",".join((filter_form.caching_key(),
str(pagination.limit),
str(pagination.offset)))
cached = flask_cache.get(key)
if cached is not None:
return cached
p = get_problems(filter_form, pagination)
cached = (render_template("problems/list_table_rows.html",
problems=p), len(p))
flask_cache.set(key, cached, timeout=60*60)
return cached
@problems.route("/")
def dashboard():
pagination = Pagination(request)
filter_form = ProblemFilterForm(request.args)
if filter_form.validate():
if request_wants_json():
p = get_problems(filter_form, pagination)
else:
list_table_rows, problem_count = \
problems_list_table_rows_cache(filter_form, pagination)
return render_template("problems/list.html",
list_table_rows=list_table_rows,
problem_count=problem_count,
filter_form=filter_form,
pagination=pagination)
else:
p = []
if request_wants_json():
return jsonify(dict(problems=p))
return render_template("problems/list.html",
problems=p,
problem_count=len(p),
filter_form=filter_form,
pagination=pagination)
@problems.route("/<int:problem_id>/")
@problems.route("/<int:problem_id>/<component_names>")
def item(problem_id, component_names=None):
components_form = ProblemComponents()
problem = db.session.query(Problem).filter(
Problem.id == problem_id).first()
if problem is None:
raise abort(404)
if component_names:
try:
(db.session.query(ProblemComponent)
.filter_by(problem_id=problem_id)
.delete())
for index, comp_name in enumerate(component_names.split(',')):
component = (db.session.query(OpSysComponent)
.filter_by(name=comp_name)
.first())
if not component:
raise ValueError("Component {} not found.".format(
comp_name))
db.session.add(ProblemComponent(problem_id=problem.id,
component_id=component.id,
order=index + 1))
reassign = (db.session.query(ProblemReassign)
.filter_by(problem_id=problem_id)
.first())
if reassign is None:
reassign = ProblemReassign(problem_id=problem_id)
reassign.date = datetime.date.today()
reassign.username = g.user.username
db.session.add(reassign)
db.session.commit()
except SQLAlchemyError:
db.session.rollback()
flash("Database transaction error.", 'error')
except ValueError as e:
db.session.rollback()
flash(str(e), 'error')
report_ids = [report.id for report in problem.reports]
solutions = []
equal_solution = lambda s: [x for x in solutions if s.cause == x.cause]
for report in problem.reports:
if report.max_certainty is not None:
osr = get_report_opsysrelease(db=db, report_id=report.id)
solution = find_solution(report, db=db, osr=osr)
if solution and not equal_solution(solution):
solutions.append(solution)
sub = (db.session.query(ReportOpSysRelease.opsysrelease_id,
func.sum(ReportOpSysRelease.count).label("cnt"))
.join(Report)
.filter(Report.id.in_(report_ids))
.group_by(ReportOpSysRelease.opsysrelease_id)
.subquery())
osreleases = (db.session.query(OpSysRelease, sub.c.cnt)
.join(sub)
.order_by(desc("cnt"))
.all())
sub = (db.session.query(ReportArch.arch_id,
func.sum(ReportArch.count).label("cnt"))
.join(Report)
.filter(Report.id.in_(report_ids))
.group_by(ReportArch.arch_id)
.subquery())
arches = (db.session.query(Arch, sub.c.cnt).join(sub)
.order_by(desc("cnt"))
.all())
exes = (db.session.query(ReportExecutable.path,
func.sum(ReportExecutable.count).label("cnt"))
.join(Report)
.filter(Report.id.in_(report_ids))
.group_by(ReportExecutable.path)
.order_by(desc("cnt"))
.all())
sub = (db.session.query(ReportPackage.installed_package_id,
func.sum(ReportPackage.count).label("cnt"))
.join(Report)
.filter(Report.id.in_(report_ids))
.group_by(ReportPackage.installed_package_id)
.subquery())
packages_known = db.session.query(Package, sub.c.cnt).join(sub).all()
packages_unknown = (db.session.query(ReportUnknownPackage,
ReportUnknownPackage.count)
.join(Report)
.filter(Report.id.in_(report_ids))).all()
packages = packages_known + packages_unknown
# creates a package_counts list with this structure:
# [(package name, count, [(package version, count in the version)])]
names = defaultdict(lambda: {"count": 0, "versions": defaultdict(int)})
for (pkg, cnt) in packages:
names[pkg.name]["name"] = pkg.name
names[pkg.name]["count"] += cnt
names[pkg.name]["versions"][pkg.evr()] += cnt
package_counts = []
for pkg in sorted(names.values(), key=itemgetter("count"), reverse=True):
package_counts.append((
pkg["name"],
pkg["count"],
sorted(pkg["versions"].items(), key=itemgetter(1), reverse=True)))
for report in problem.reports:
for backtrace in report.backtraces:
fid = 0
for frame in backtrace.frames:
fid += 1
frame.nice_order = fid
bt_hashes = (db.session.query(ReportHash.hash)
.join(Report)
.join(Problem)
.filter(Problem.id == problem_id)
.distinct(ReportHash.hash).all())
forward = {"problem": problem,
"osreleases": metric(osreleases),
"arches": metric(arches),
"exes": metric(exes),
"package_counts": package_counts,
"solutions": solutions,
"components_form": components_form
}
if not bt_hashes:
logger.warning("No backtrace hashes found for problem #%d", problem_id)
else:
# Generate a permalink for this problem. We do this by uniformly picking
# (at most) 10 hashes from the list. This ensures the selected hashes are
# more or less representative of the problem.
k = min(len(bt_hashes), 10)
# A hint of determinism in this uncertain world.
r = random.Random(problem_id)
hashes_sampled = r.sample(bt_hashes, k)
permalink_query = "&".join("bth={}".format(bth) for (bth,) in hashes_sampled)
forward["permalink_query"] = permalink_query
if request_wants_json():
return jsonify(forward)
is_maintainer = is_problem_maintainer(db, g.user, problem)
forward["is_maintainer"] = is_maintainer
forward["extfafs"] = get_external_faf_instances(db)
if report_ids:
bt_diff_form = BacktraceDiffForm()
bt_diff_form.lhs.choices = [(id, id) for id in report_ids]
bt_diff_form.rhs.choices = bt_diff_form.lhs.choices
forward['bt_diff_form'] = bt_diff_form
return render_template("problems/item.html", **forward)
@problems.route("/bthash/", endpoint="bthash_permalink", methods=["GET", "POST"])
@problems.route("/bthash/<bthash>/", methods=["GET", "POST"])
def bthash_forward(bthash=None):
# single hash
# component ids can't be accessed through components_form object because of
# redirection, it must be passed to the item function as an parameter
if request.method == 'POST':
component_names = request.form.get('component_names')
else:
component_names = None
if bthash is not None:
db_report = get_report(db, bthash)
if db_report is None:
raise abort(404)
if not db_report.backtraces:
return render_template("reports/waitforit.html")
if db_report.problem is None:
return render_template("problems/waitforit.html")
return redirect(url_for("problems.item",
problem_id=db_report.problem.id,
component_names=component_names))
# multiple hashes as get params
hashes = request.values.getlist('bth')
if hashes:
problems_ = (db.session.query(Problem)
.join(Report)
.join(ReportHash)
.filter(ReportHash.hash.in_(hashes))
.distinct(Problem.id)
.all())
if not problems_:
abort(404)
if len(problems_) == 1:
return redirect(url_for("problems.item",
problem_id=problems_[0].id,
component_names=component_names))
return render_template("problems/multiple_bthashes.html",
problems=problems_)
return abort(404)