From 0680c3267af5ce6397e2f37cb30ffcd80161dba0 Mon Sep 17 00:00:00 2001 From: Jono Yang Date: Mon, 23 Jun 2025 17:11:47 -0700 Subject: [PATCH 1/2] Raise NotImplementedError instead of returning it Signed-off-by: Jono Yang --- src/univers/version_range.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/univers/version_range.py b/src/univers/version_range.py index bee601ef..4c2a0baf 100644 --- a/src/univers/version_range.py +++ b/src/univers/version_range.py @@ -78,7 +78,7 @@ def from_native(cls, string): Return a VersionRange built from a scheme-specific, native version range ``string``. Subclasses can implement. """ - return NotImplementedError + raise NotImplementedError @classmethod def from_natives(cls, strings): @@ -86,7 +86,7 @@ def from_natives(cls, strings): Return a VersionRange built from a ``strings`` list of scheme- specific native version range strings. Subclasses can implement. """ - return NotImplementedError + raise NotImplementedError def to_native(self, *args, **kwargs): """ @@ -95,7 +95,7 @@ def to_native(self, *args, **kwargs): extra arguments (such as a package name that some scheme may require like for deb and rpm.) """ - return NotImplementedError + raise NotImplementedError @classmethod def from_string(cls, vers, simplify=False, validate=False): @@ -176,7 +176,7 @@ def from_versions(cls, sequence): such as ["3.0.0", "1.0.1b", "3.0.2", "0.9.7a", "1.1.1ka"] """ if not cls.scheme or not cls.version_class: - return NotImplementedError + raise NotImplementedError constraints = [] for version in sequence: From 1ce70c043a9fbf085f28a6f11fda2356aa99a89c Mon Sep 17 00:00:00 2001 From: Jono Yang Date: Tue, 24 Jun 2025 11:47:46 -0700 Subject: [PATCH 2/2] Update CHANGELOG.rst Signed-off-by: Jono Yang --- CHANGELOG.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index b495b28b..20ddc8c9 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,6 +1,11 @@ Changelog ========= +Version v31.0.0 +---------------- + +- Raise instead of returning ``NotImplementedError`` in ``version_range.VersionRange`` methods. https://github.com/aboutcode-org/univers/pull/158 + Version v30.12.1 ----------------